1772027 - Recent Release 91.8.1 announced a fix CLIENTID extension to SMTP was not supported by smtp-js - but it is still broken

Status: RESOLVED FIXED

(MailNews Core :: Networking: SMTP, defect)

Description

[DevTeam]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:100.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

A patch was submitted a while back to add ClientID functionality into the JSM version of SMTP Client (comm-central/mailnews/compose/src/SmtpClient.jsm).

It is confirmed that in release 91.8.1 and newer that the patched code is indeed in place.

Actual results:

When testing SMTP send against a ClientID enabled server, it failed to send a CLIENTID command in the session. Confirmed that hidden setting in the Config Editor had the ClientID setting enabled for SMTP, and that the connection was secured using StartTLS

Expected results:

Looking closer at the code, it looks like some other merges that came in with the ClientID patch merge possibly changed the name of the variable from:

this._secureTransport

to

this._secureMode

Observed in Ubuntu package source for thunderbird-91.9.1+build1

However, looking at the source code on searchfox.org, the code listed there retains the variable name this._secureTransport ...

Confirmed as well via a Mercurial checkout that the variable name this._secureTransport is universally used.

So, why does the Ubuntu package use this._secureMode ?

Not sure how that would have happened?

Comment 1

[Magnus Melin [:mkmelin]]

https://searchfox.org/comm-esr91/rev/4732e5ce696f2c33f616e7105ce253c2e89057ae/mailnews/compose/src/SmtpClient.jsm#916

It seems on 91 the variable name had already changed, so the backport of bug 1759197 would have needed to change the variable name... And unfortunately the test to prove clientid works will bypass this particular condition!

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug_1772027____91_only__fix_bug_1759197_backport_so_that_smtp_clientid_would_work__r_rjl.diff

Comment 3

[Rob Lemley [:rjl]]

Comment on attachment 9279102 [details] [diff] [review]
Bug_1772027____91_only__fix_bug_1759197_backport_so_that_smtp_clientid_would_work__r_rjl.diff

Review of attachment 9279102 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense to me.
Approved for next 91 release, most likely 91.11.0.

Comment 4

[Rob Lemley [:rjl]]

Thunderbird 91.11.0:
https://hg.mozilla.org/releases/comm-esr91/rev/17b6525014b5