Closed
Bug 1772094
Opened 2 years ago
Closed 2 years ago
Use plain object for lazy getter in docshell/ and dom/
Categories
(Core :: DOM: Core & HTML, task)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
103 Branch
Tracking | Status | |
---|---|---|
firefox103 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(7 files, 1 obsolete file)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
+++ This bug was initially created as a clone of Bug #1772007 +++
Many JSM files define lazy getters on the per-JSM global this
object.
The global this
object doesn't exist in ES module, and those lazy getters need to be moved to a plain object const lazy = {};
, and each consumer needs to be rewritten to refer the lazy getter with lazy.foo
.
This migration is done by automated script in bug 1608279.
Assignee | ||
Updated•2 years ago
|
Summary: Use plain object for lazy getter in dom/ → Use plain object for lazy getter in docshell/ and dom/
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
Depends on D147908
Assignee | ||
Comment 3•2 years ago
|
||
Depends on D147909
Assignee | ||
Comment 4•2 years ago
|
||
Depends on D147910
Assignee | ||
Comment 5•2 years ago
|
||
Depends on D147911
Assignee | ||
Comment 6•2 years ago
|
||
Depends on D147912
Assignee | ||
Comment 7•2 years ago
|
||
Depends on D147913
Assignee | ||
Comment 8•2 years ago
|
||
Depends on D147914
Updated•2 years ago
|
Attachment #9279156 -
Attachment is obsolete: true
Assignee | ||
Updated•2 years ago
|
Keywords: leave-open
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/fa1af8b46a60 Part 3: Use plain object for lazy getter in dom/ipc/. r=mconley https://hg.mozilla.org/integration/autoland/rev/27679a608008 Part 4: Use plain object for lazy getter in dom/manifest/. r=florian https://hg.mozilla.org/integration/autoland/rev/24140d76ff36 Part 5: Use plain object for lazy getter in dom/media/. r=jib https://hg.mozilla.org/integration/autoland/rev/cc7880587ad5 Part 6: Use plain object for lazy getter in dom/notification/. r=mossop https://hg.mozilla.org/integration/autoland/rev/16090848f1c7 Part 8: Use plain object for lazy getter in dom/system/. r=necko-reviewers,kershaw
Comment 10•2 years ago
|
||
bugherder |
Comment 11•2 years ago
|
||
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/55a802c01286 Part 1: Use plain object for lazy getter in docshell/base/. r=mak https://hg.mozilla.org/integration/autoland/rev/bd77e0e63a6c Part 7: Use plain object for lazy getter in dom/push/. r=dragana
Assignee | ||
Updated•2 years ago
|
Keywords: leave-open
Comment 12•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/55a802c01286
https://hg.mozilla.org/mozilla-central/rev/bd77e0e63a6c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox103:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•