1772144 - Missing markers that matches browsertime metrics

Status: RESOLVED DUPLICATE of bug 1691820

(Testing :: Raptor, enhancement, P2)

Description

[:gerard-majax]

Tracking perf regression reported by https://bugzilla.mozilla.org/show_bug.cgi?id=1769903 I came up to the point where the only way to repro the issue and get new metrics is:

• push to try, wait 4h (and currently profiling is broken on try)
• run raptor locally

This makes analyzing the regression very complicated. Profiling the process does not yield easily markers that matches the metrics we are targetting (namely, fcp, ContentfulSpeedIndex currently, but I am also looking for FirstVisualChange, LastVisuaChange, fnbpaint).

Either we have existing markers matching those, and it would be nice we get:

• mention of those on the bug created
• doc listing the pairings between our markers and browsertime metrics

Or we add them, possibly using the same names for ease of use

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Sean, can we add a marker that matches FCP exactly?

Comment 2

[Sean Feng [:sefeng211]]

There are a couple of things mentioned in the description.

We have,

• FCP - which can be easily added to the profiler, so sure :)
• fnbpaint - which we have in the profile already (FirstNonBlankPaint)
• ContentfulSpeedIndex - I think we also have this in the profile if the profile is being collected from browsertime runs.
• FirstVisualChange and LastVisualChange - They are browsertime specific metrics, so the changes need to there.

Comment 3

[Greg Mierzwinski [:sparky]]

For CSI, we have the progress but not the exact location of the final CSI which is what :gerard is looking for. We can add a marker for that in browsertime (like for first/last change).

Comment 4

[Markus Stange [:mstange]]

(In reply to Alexandre LISSY :gerard-majax from comment #0)

(and currently profiling is broken on try)

Is there a bug for this?

Comment 5

[Greg Mierzwinski [:sparky]]

Yes, it's bug 1771987. I have a patch waiting for a review there.

Comment 6

[:gerard-majax]

Attachment: patch

Comment 7

[:gerard-majax]

Just sharing the garbage patch I had

Comment 8

[Kash Shampur [:kshampur] ⌚EST]

hey Nazim, with the recent improvement for profiler integration in browsertime, is there a chance we've resolved some of the issues here?

Comment 9

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

My PR in the profiler frontend adds markers for ContentfulSpeedIndex, PerceptualSpeedIndex, SpeedIndex now. We still miss some markers like fcp though. I will work on adding this but it looks like we have a dedicated bug for it already (Bug 1691820). Closing this in favor of that one.