1772150 - Broken sync status is not reset after successful sync

Status: RESOLVED FIXED

(Firefox :: Remote Settings Client, enhancement)

Description

[Mathieu Leplatre [:leplatrem]]

Steps to reproduce

1. Sync fails consistently (eg. >= 10 times).
2. Sync is detected as broken
3. Sync succeeds

Expected behaviour

Sync should not be "broken" anymore.

Observer behaviour

Sync state is still broken.

Comment 1

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1772150 - Reset broken sync status after success r?gbeckley

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebf238f3db94
Reset broken sync status after success r=gbeckley

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ebf238f3db94

Comment 4

[Mathieu Leplatre [:leplatrem]]

Comment on attachment 9279116 [details]
Bug 1772150 - Reset broken sync status after success r?gbeckley

Beta/Release Uplift Approval Request

• User impact if declined: No impact on users. But without this patch, the Telemetry that we collect about broken synchronization is flawed.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change only affects the detection of the broken sync state
• String changes made/needed:
• Is Android affected?: Yes

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9279116 [details]
Bug 1772150 - Reset broken sync status after success r?gbeckley

Approved for 102 beta 3, thanks.

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/91830085d5aa