Closed
Bug 1772155
Opened 2 years ago
Closed 2 years ago
Migrate SessionData processing out of target-actor-mixin to dedicated modules
Categories
(DevTools :: Framework, enhancement)
DevTools
Framework
Tracking
(firefox105 fixed)
RESOLVED
FIXED
105 Branch
| Tracking | Status | |
|---|---|---|
| firefox105 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
For now, the processing of each new Session Data Entry is added in middle of TargetActorMixin:
https://searchfox.org/mozilla-central/rev/3419858c997f422e3e70020a46baae7f0ec6dacc/devtools/server/actors/targets/target-actor-mixin.js#51-150
This doesn't scale and put lots of heterogeneous logic in middle of this target actor code.
|
Assignee | |
Comment 1•2 years ago
|
||
This will help keep target-actor-mixin generic and move each data entry processing
to a dedicated module.
|
||
Updated•2 years ago
|
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
|
||
Comment 2•2 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:ochameau, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.
Flags: needinfo?(poirot.alex)
Flags: needinfo?(nchevobbe)
|
||
Updated•2 years ago
|
Flags: needinfo?(nchevobbe)
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/039f45ee61e7 [devtools] Move all session data entry processing into a dedicated module. r=nchevobbe
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox105:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
|
|
Assignee | |
Updated•2 years ago
|
Flags: needinfo?(poirot.alex)
You need to log in
before you can comment on or make changes to this bug.
Description
•