1772192 - Main menu items have black text on dark-blue background when hovered

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Thomas D. (:thomas8)]

Main menu items have black text on dark-blue background when hovered, which makes for poor contrast. I guess we'll want the generic shade of grey as in app menu.

Not yet seen in 101.0b4 (64-bit), so this must have regressed pretty recently.

Comment 1

[Thomas D. (:thomas8)]

Attachment: Screenshot 1: Black menu text on dark-blue background (poor contrast)

Seen on 103.0a1 (2022-06-01) (64-bit), Win10

Comment 2

[Richard Marti (:Paenglab)]

We use the system colours for the main menu elements. Unfortunately on W10 they aren't correctly/appropriately picked. I checked different applications and the highlight colour isn't consistent. Because of this I go back to the grey highlight background like FX does. This will affect W11 too as there is no special media query for W11.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Bug 1772192 - Don't use the -moz-MenuHover colors on Windows 10+. r=aleca

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3c7ce2a7cba3
Don't use the -moz-MenuHover colors on Windows 10+. r=aleca

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9279396 [details]
Bug 1772192 - Don't use the -moz-MenuHover colors on Windows 10+. r=aleca

[Approval Request Comment]
User impact if declined: on Window 10 hard readable active main menuitems
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9279396 [details]
Bug 1772192 - Don't use the -moz-MenuHover colors on Windows 10+. r=aleca

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 102.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/2d45f12ec422