1772252 - the argument --debugger-args seems to have broken (and it doesn't show up in help)

Status: NEW

(Testing :: General, defect, P3)

Description

[Randell Jesup [:jesup] (needinfo me)]

./mach test --debugger=rr --debugger-args="record --disable-avx-512" (for pernosco recordings) no longer works, because the args in --debugger-args aren't passed to the rr commandline.

This used to work. I see multiple references to --debugger-args in our python code, but ./mach test --help doesn't list --debugger-args. Thinking back, I think this has been broken for a while. (my "record -M" args weren't printing when values)

no error is given (it appears to accept it), but the args aren't included in the command line.

It can be worked around by modifying mozdebug.py to include:
"rr": {"interactive": True, "args": ["record", "--disable-avx-512"]},
in the _DEBUGGER_INFO array

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

I believe I was using xpcshell tests when I saw this, if it matters

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:ahal, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Manuel Bucher [:manuel]]

Is there a workaround here? (using workaround from comment 0) I know that I used to be able to pass this command, so I'm assuming this doesn't work on some kinds of tests. I'm now working in a different directory with different tests, and I can't run the tests with pernosco arguments.

It doesn't work here for example:

$ ./mach test --debugger=rr --debugger-args="record --disable-avx-512 --disable-cpuid-features-ext 0xfc230000,0x2c42,0xc" toolkit/components/antitracking/bouncetrackingprotection/test/browser/browser_bouncetracking_stateful_storage.js --headless
UNKNOWN TEST: --debugger-args=record --disable-avx-512 --disable-cpuid-features-ext 0xfc230000,0x2c42,0xc