Closed
Bug 1772284
Opened 3 years ago
Closed 3 years ago
ImageLoader::Notify profiler label creates extra variables on the stack
Categories
(Core :: Layout: Images, Video, and HTML Frames, defect)
Core
Layout: Images, Video, and HTML Frames
Tracking
()
RESOLVED
FIXED
103 Branch
| Tracking | Status | |
|---|---|---|
| firefox103 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(1 file)
Apparently this is because of the conditional on the profiler being active here https://searchfox.org/mozilla-central/rev/c8e15e17bc6fd28f558c395c948a6251b38774ff/tools/profiler/public/ProfilerLabels.h#110,113 and bug 1771776 tracks that.
But we can avoid that by just using AUTO_PROFILER_LABEL_DYNAMIC_CSTR
|
Assignee | |
Comment 1•3 years ago
|
||
Apparently this is because of the conditional on the profiler being active here https://searchfox.org/mozilla-central/rev/c8e15e17bc6fd28f558c395c948a6251b38774ff/tools/profiler/public/ProfilerLabels.h#110,113 and bug 1771776 tracks that.
But we can avoid that by just using AUTO_PROFILER_LABEL_DYNAMIC_CSTR
|
||
Updated•3 years ago
|
Assignee: nobody → tnikkel
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•3 years ago
|
Summary: ImageLoader::Notify profiler label doesn't appear → ImageLoader::Notify profiler label creates extra variables on the stack
|
|
||
Updated•3 years ago
|
Attachment #9279384 -
Attachment description: Bug 1772284. Make ImageLoader::Notify profiler label show up. r?emilio,gerald → Bug 1772284. Make ImageLoader::Notify profiler label not create extra variables on the stack. r?emilio,gerald
Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df37233057ab
Make ImageLoader::Notify profiler label not create extra variables on the stack. r=emilio
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox103:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•