[FIXr]checking the base uri for security checks is bogus...

RESOLVED FIXED in mozilla1.3alpha

Status

()

Core
Security
P1
critical
RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla1.3alpha
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

nsHTMLFormElement and nsScriptLoader have these bogus security checks....
Created attachment 104455 [details] [diff] [review]
fix
Severity: normal → critical
Priority: -- → P1
Summary: checking the base uri for security checks is bogus... → [FIX]checking the base uri for security checks is bogus...
Target Milestone: --- → mozilla1.3alpha
hmm.... as bbaetz just pointed out, you can't set the base url to something you
could not link to anyway... so perhaps this is a non-issue.... (if it _is_ an
issue, we should fix the CSSLoader as well).
We need to decide on what the right thing is so I can fix the remaining
(correctness) problem in bug 171924
Blocks: 171924
Comment on attachment 104455 [details] [diff] [review]
fix

This seems right to me. No matter what you set the base to (even if you're
allowed to set it to whatever URI you're setting it to), the security checks
should IMO use the document URI since that's who's really loading the data, or
whatever.

sr=jst, Mitch, you ok with this?
Attachment #104455 - Flags: superreview+
Created attachment 104908 [details] [diff] [review]
add CSSLoader to the list of victims

This just adds the last chunk for CSSloader...
Attachment #104455 - Attachment is obsolete: true
Comment on attachment 104908 [details] [diff] [review]
add CSSLoader to the list of victims

Yes, this looks more correct. r=mstoltz.
Attachment #104908 - Flags: review+
Summary: [FIX]checking the base uri for security checks is bogus... → [FIXr]checking the base uri for security checks is bogus...
Comment on attachment 104908 [details] [diff] [review]
add CSSLoader to the list of victims

a=blizzard on behalf of drivers for 1.2final.

Make sure you get this in by the tree closure on Nov 5th, 2002.  If you don't,
it's going to have to wait until the branch is finished being cut.
Attachment #104908 - Flags: approval+
checked in
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.