1772417 - Make WPT tests pass: performance-measure-invalid.worker.html

Status: VERIFIED FIXED

(Core :: DOM: Performance, enhancement)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We currently pass 1/2 tests, according to wpt.fyi: https://wpt.fyi/results/user-timing/performance-measure-invalid.worker.html?label=experimental&label=master&aligned

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1772417 - align IsPerformanceTimingAttribute to user-timing spec. r=sefeng

In my opinion, this makes the code clearer because the implementation can more
closely match the spec and the code flow does not jump across subclasses and
their separate files. This change will be used by the following patch.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1772417 - correct web-platform convert name to timestamp. r=sefeng

This fixes the performance-measure-invalid.worker.html test. The test failed
because User Timing L3 section 4.2, "Convert a name to a timestamp", was not
implemented - the code was presumably residual from an earlier version of User
Timing. In particular, we never threw if the global object was not a Window. We
also corrected the code order for section 4.1, "Convert a mark to a timestamp",
which was incorrect but didn't cause any tests to fail.

Depends on D154819

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1772417 - add mark then measure on PerformanceTiming attribute test. r=sefeng

The previous implementation of our code had the code ordering reversed for User
Timing L3 section 4.1, "Convert a mark to a timestamp": it checked if a mark
exists for the given name then checked if the name matched a PerformanceTiming
attribute rather than the reverse. This test validates the correct order. Since
this behavior is presumably left over from an older version of the spec, it
seems worthwhile to have the test.

Depends on D154820

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/819f3d83aaa8
align IsPerformanceTimingAttribute to user-timing spec. r=sefeng
https://hg.mozilla.org/integration/autoland/rev/fda98ba4b551
correct web-platform convert name to timestamp. r=sefeng
https://hg.mozilla.org/integration/autoland/rev/307be8a3b4e1
add mark then measure on PerformanceTiming attribute test. r=sefeng

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35521 for changes under testing/web-platform/tests

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/819f3d83aaa8
https://hg.mozilla.org/mozilla-central/rev/fda98ba4b551
https://hg.mozilla.org/mozilla-central/rev/307be8a3b4e1

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I verified the tests pass in the latest Nightly locally on wpt.fyi and the wpt.fyi dashboard now shows the tests are passing: https://wpt.fyi/results/user-timing/performance-measure-invalid.worker.html?label=experimental&label=master&aligned&view=subtest.