1772499 - Import/export tab shows wrong favicon

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Martin Giger [:freaktechnik]]

The import/export tab shows the wrong icon. It defines the import icon as its favicon, however the draft icon is shown instead.

Regression window: https://hg.mozilla.org/comm-central/pushloghtml?fromchange=6c2b6733806cc4879b187b0c7dfcf21314158589&tochange=3a43bdbcd359a4de7085b237243fd5b48a8f317e

The regression is caused by the assignment of the location hash, which triggers a location change, for which specialTabs.js clears the favicon, leading to the default icon being used.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1772499 - Don't clear favicon on hash change and show export icon for export page. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/980907fea815
Don't clear favicon on hash change and show export icon for export page. r=Paenglab

Comment 3

[Alessandro Castellani [:aleca]]

This is beta 102 uplift worthy, thanks for fixing it!

Comment 4

[Martin Giger [:freaktechnik]]

Comment on attachment 9279572 [details]
Bug 1772499 - Don't clear favicon on hash change and show export icon for export page. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1764398
User impact if declined: Wrong favicon shown for export/import tab
Testing completed (on c-c, etc.): Tested on c-c
Risk to taking this patch (and alternatives if risky): Could show another wrong favicon instead, could not be clearing the favicon when we should on some tabs. Though I'd rate risk for both of these low.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9279572 [details]
Bug 1772499 - Don't clear favicon on hash change and show export icon for export page. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 102.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/026bfd02be78