1772537 - Intermittent toolkit/components/glean/tests/xpcshell/test_GIFFTIPC.js | single tracking bug | xpcshell return code: 0

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=380154545&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/KsWvHLMsTv2ejFj2roa6Ig/runs/0/artifacts/public/logs/live_backing.log

---

INFO -  TEST-START | toolkit/components/glean/tests/xpcshell/test_GIFFTIPC.js
[task 2022-06-03T13:23:05.684Z] 13:23:05  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/glean/tests/xpcshell/test_GIFFTIPC.js | xpcshell return code: 0
[task 2022-06-03T13:23:05.712Z] 13:23:05     INFO -  TEST-INFO took 2357ms
[task 2022-06-03T13:23:05.712Z] 13:23:05     INFO -  >>>>>>>
[task 2022-06-03T13:23:05.713Z] 13:23:05     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2022-06-03T13:23:05.713Z] 13:23:05     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2022-06-03T13:23:05.713Z] 13:23:05     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2022-06-03T13:23:05.714Z] 13:23:05     INFO -  running event loop
[task 2022-06-03T13:23:05.714Z] 13:23:05     INFO -  toolkit/components/glean/tests/xpcshell/test_GIFFTIPC.js | Starting setup test_setup
[task 2022-06-03T13:23:05.714Z] 13:23:05     INFO -  (xpcshell/head.js) | test test_setup pending (2)
[task 2022-06-03T13:23:05.715Z] 13:23:05     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2022-06-03T13:23:05.715Z] 13:23:05     INFO -  (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2022-06-03T13:23:05.715Z] 13:23:05     INFO -  (xpcshell/head.js) | test test_setup finished (2)
[task 2022-06-03T13:23:05.716Z] 13:23:05     INFO -  toolkit/components/glean/tests/xpcshell/test_GIFFTIPC.js | Starting run_child_stuff
<...>
INFO -  TEST-PASS | toolkit/components/glean/tests/xpcshell/test_GIFFTIPC.js | test_child_metrics - [test_child_metrics : 291] 2 == 2
[task 2022-06-03T13:23:05.761Z] 13:23:05  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/glean/tests/xpcshell/test_GIFFTIPC.js | test_child_metrics - [test_child_metrics : 299] Histogram's in milliseconds. - 14 >= 15
[task 2022-06-03T13:23:05.761Z] 13:23:05     INFO -  Z:/task_1654260142/build/tests/xpcshell/tests/toolkit/components/glean/tests/xpcshell/test_GIFFTIPC.js:test_child_metrics:299
[task 2022-06-03T13:23:05.761Z] 13:23:05     INFO -  Z:\task_1654260142\build\tests\xpcshell\head.js:_do_main:240
[task 2022-06-03T13:23:05.762Z] 13:23:05     INFO -  Z:\task_1654260142\build\tests\xpcshell\head.js:_execute_test:597
[task 2022-06-03T13:23:05.762Z] 13:23:05     INFO -  -e:null:1
[task 2022-06-03T13:23:05.762Z] 13:23:05     INFO -  exiting test
[task 2022-06-03T13:23:05.762Z] 13:23:05     INFO -  Unexpected exception NS_ERROR_ABORT:
[task 2022-06-03T13:23:05.763Z] 13:23:05     INFO -  _abort_failed_test@Z:\task_1654260142\build\tests\xpcshell\head.js:868:20
[task 2022-06-03T13:23:05.763Z] 13:23:05     INFO -  do_report_result@Z:\task_1654260142\build\tests\xpcshell\head.js:969:5
[task 2022-06-03T13:23:05.763Z] 13:23:05     INFO -  Assert<@Z:\task_1654260142\build\tests\xpcshell\head.js:75:21
[task 2022-06-03T13:23:05.764Z] 13:23:05     INFO -  proto.report@resource://testing-common/Assert.jsm:228:10
[task 2022-06-03T13:23:05.764Z] 13:23:05     INFO -  compareNumbers@resource://testing-common/Assert.jsm:522:10
[task 2022-06-03T13:23:05.764Z] 13:23:05     INFO -  greaterOrEqual@resource://testing-common/Assert.jsm:562:18
[task 2022-06-03T13:23:05.765Z] 13:23:05     INFO -  test_child_metrics@Z:/task_1654260142/build/tests/xpcshell/tests/toolkit/components/glean/tests/xpcshell/test_GIFFTIPC.js:299:12
[task 2022-06-03T13:23:05.765Z] 13:23:05     INFO -  _do_main@Z:\task_1654260142\build\tests\xpcshell\head.js:240:6
[task 2022-06-03T13:23:05.765Z] 13:23:05     INFO -  _execute_test@Z:\task_1654260142\build\tests\xpcshell\head.js:597:5
[task 2022-06-03T13:23:05.765Z] 13:23:05     INFO -  @-e:1:1
[task 2022-06-03T13:23:05.766Z] 13:23:05     INFO -  exiting test
[task 2022-06-03T13:23:05.766Z] 13:23:05     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "Metric had 1 error(s) of type invalid_label!"]"
[task 2022-06-03T13:23:05.766Z] 13:23:05     INFO -  <<<<<<<
[task 2022-06-03T13:23:05.779Z] 13:23:05     INFO -  TEST-START | browser/components/syncedtabs/test/xpcshell/test_SyncedTabsDeckComponent.js

Comment 1

[Chris H-C :chutten]

[task 2022-06-03T13:23:05.761Z] 13:23:05 WARNING - TEST-UNEXPECTED-FAIL | toolkit/components/glean/tests/xpcshell/test_GIFFTIPC.js | test_child_metrics - [test_child_metrics : 299] Histogram's in milliseconds. - 14 >= 15

Oh no, not clocks again. Guess we change this line to 14... but why? The epsilon we use on the Glean figure is 40kns (or 0.04ms).

Hrm, the Histogram's in millis. I wonder if we truncate instead of rounding someplace... Ah, Telemetry truncates for us in this static_cast. I guess that means either or both of these timers could be slightly shy of their 5s or 10s mark, meaning we get 4s and/or 9s meaning we could have figures as low as 13s.

Guess we should make this >= 13, then, just to be on the safe side.

Comment 2

[Intermittent Failures Robot]

3 failures in 2917 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 3

Platform and build breakdown:

• windows7-32-shippable-qr: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1772537&startday=2022-05-30&endday=2022-06-05&tree=all

Comment 3

[Intermittent Failures Robot]

6 failures in 3336 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 6

Platform and build breakdown:

• android-em-7-0-x86_64-lite-qr: 2
  • debug: 2
• android-em-7-0-x86_64-qr: 3
  • debug-isolated-process: 2
  • debug: 1
• linux1804-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1772537&startday=2022-06-06&endday=2022-06-12&tree=all

Comment 4

[Intermittent Failures Robot]

1 failures in 3057 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform and build breakdown:

• windows7-32-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1772537&startday=2022-08-01&endday=2022-08-07&tree=all

Comment 5

[Perry McManis [:perry.mcmanis]]

Attachment: Bug 1772537 - intermittent test failure caused by adding two numbers truncated by cast caused test value to fall below expected minimum r?chutten

Comment 6

[Perry McManis [:perry.mcmanis]]

So this fix works IFF we restrict additions to two instances of 5 and 10, would a comment to this effect be useful? It seems a bit like a "don't mess with this test" comment though and potentially unhelpful.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c0557b89eff
intermittent test failure caused by adding two numbers truncated by cast caused test value to fall below expected minimum r=chutten

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1c0557b89eff