1772578 - TypeError in updater

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect)

Description

[Ian Moody [:Kwan] (UTC+1)]

moz-phab will currently throw a TypeError while trying to raise a friendly error if it detects the current python version is too out of date to install the latest version of moz-phab on pypi. This is because it tries to call str.join() on a list of ints, which as documented isn't allowed:

A TypeError will be raised if there are any non-string values in iterable

https://github.com/mozilla-conduit/review/blob/82e1aef340382638d3e12544a5b0dcfe954a1637/mozphab/updater.py#L50

        # convert ">=3.6" to (3, 6)
        try:
            required_python_version = tuple(
                [int(i) for i in pypi_info["requires_python"][2:].split(".")]
            )
        except ValueError:
            required_python_version = ()

        if sys.version_info < required_python_version:
            raise Error(
                "Unable to upgrade to version {}.\n"
                "MozPhab requires Python in version >= {}".format(
                    pypi_info["version"], ".".join(required_python_version)
                )
            )

Comment 1

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Bug 1772578 - Use pypi's minimum Python info directly in error message. r=zeid

Rather than trying to call str.join() on a tuple of ints and throwing a
TypeError.