1772599 - Ensure sanitized prefs are not removed from hashtable in Content Processes

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect, P1)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

In a subprocess, if a pref has no value, it will not be added to the hashtable - and if it's not in the hashtable, we do not have an opportunity to crash when it is accessed. This has lead to undefined string prefs (like general.useragent.override) not leading to crashes when accessed.

We need to fix this and retest to ensure we are allowlisting the prefs content processes care about for operation and for tests.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1772599 - Set pref sanitizations prefs in the content process r?KrisWright

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1772599 - Ensure that sanitized prefs make it into the hashtable in the content processes r?KrisWright

Depends on D148311

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1772599 - Move crashes further up the stack to handle NoneType prefs in the content process r?KrisWright

Depends on D148312

Comment 4

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1772599 - Do not start checking prefs until they've been initialized r?KrisWright

Comment 5

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1772599 - Add prefs to the dynamic override list r?KrisWright

Depends on D148316

Comment 6

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1772599 - Do not treat init-once prefs as sanitizable r?KrisWright

Depends on D149293

Comment 7

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1772599 - Use a temporary pref for a few weeks while we vette the behavior r?freddyb

Depends on D149294

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd306a37d456
Set pref sanitizations prefs in the content process r=KrisWright
https://hg.mozilla.org/integration/autoland/rev/94cb2c0fd685
Ensure that sanitized prefs make it into the hashtable in the content processes r=KrisWright
https://hg.mozilla.org/integration/autoland/rev/f11e6ba5d5ac
Move crashes further up the stack to handle NoneType prefs in the content process r=KrisWright
https://hg.mozilla.org/integration/autoland/rev/8ff6037c838e
Do not start checking prefs until they've been initialized r=KrisWright
https://hg.mozilla.org/integration/autoland/rev/79217f35a4e6
Add prefs to the dynamic override list r=KrisWright
https://hg.mozilla.org/integration/autoland/rev/4bb2e549baa1
Do not treat init-once prefs as sanitizable r=KrisWright
https://hg.mozilla.org/integration/autoland/rev/008d34e53555
Use a temporary pref for a few weeks while we vette the behavior r=freddyb

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/bd306a37d456
https://hg.mozilla.org/mozilla-central/rev/94cb2c0fd685
https://hg.mozilla.org/mozilla-central/rev/f11e6ba5d5ac
https://hg.mozilla.org/mozilla-central/rev/8ff6037c838e
https://hg.mozilla.org/mozilla-central/rev/79217f35a4e6
https://hg.mozilla.org/mozilla-central/rev/4bb2e549baa1
https://hg.mozilla.org/mozilla-central/rev/008d34e53555