1772684 - Support the fenced code block's syntax-highlighting language part without `lang=` prefix

Status: RESOLVED FIXED

(Conduit :: Phabricator, enhancement)

Description

[Tooru Fujisawa [:arai]]

Steps to reproduce:

1. comment on the phabricator revision with the following

https://searchfox.org/mozilla-central/rev/f818cf7d7a46728a66b4dcfece73dc017da43f98/js/src/builtin/TestingFunctions.cpp#585-589
```cpp
static bool IsLCovEnabled(JSContext* cx, unsigned argc, Value* vp) {
  CallArgs args = CallArgsFromVp(argc, vp);
  args.rval().setBoolean(coverage::IsLCovEnabled());
  return true;
}
```

Actual result:
the cpp becomes part of the fenced code block

Expected result:
the cpp part is handled as language for the syntax highlighting, or just ignored

Comment 1

[Tooru Fujisawa [:arai]]

looks like it's not markdown, but it's another syntax called "remarkup"
https://phabricator.services.mozilla.com/book/phabricator/article/remarkup/

Comment 2

[Tooru Fujisawa [:arai]]

and the following works:

https://searchfox.org/mozilla-central/rev/f818cf7d7a46728a66b4dcfece73dc017da43f98/js/src/builtin/TestingFunctions.cpp#585-589
```lang=cpp
static bool IsLCovEnabled(JSContext* cx, unsigned argc, Value* vp) {
  CallArgs args = CallArgsFromVp(argc, vp);
  args.rval().setBoolean(coverage::IsLCovEnabled());
  return true;
}
```

I wonder if we can tweak the syntax to support language without lang=

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: GitHub Pull Request

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

(Updating the subject to include "syntax-highlighting" because I almost filed a dupe of this and I expect this will now be a very common request as I do constantly find myself using the new searchfox options and then constantly a little sad that phabricator doesn't handle it while github does in its github flavored markdown fenced code block support. I'm very excited to see :arai already has a patch up, though! Woo!)

Comment 5

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-conduit/phabricator/commit/341ac91da393ae54c86203f8a6c12f35225a7fae