1772808 - mach bootstrap fails to install minidump-stackwalk

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect, P3)

Description

[Dave Townsend [:mossop]]

After encountering a crash in a local test I see the message:

MINIDUMP_STACKWALK binary not found: ~/.mozbuild/minidump_stackwalk/minidump_stackwalk. Use mach bootstrap --no-system-changes to install minidump-stackwalk

I have run the command mentioned and no minidump-stackwalk is installed.

Comment 1

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Hey Dave,

I just tried running ./mach bootstrap --no-system-changes and minidump-stackwalk installed correctly on both Windows10 and Ubuntu.

I'm not sure what test you're running, but could you confirm that a ./mozbuild/minidump-stackwalk/ directory doesn't exist for you?

I'm thinking it might be a difference between the - and _ in what's expected in what you're running versus what's actually there in the ./mozbuild directory.

If that's not the case (And no minidump stackwalk directory of any kind exists), could you delete the ./mozbuild/toolchains/ directory and re-run the ./mach bootstrap --no-system-changes command and paste the output here? Also, what operating system are you on?

Comment 2

[Mike Hommey [:glandium]]

Have you set MINIDUMP_STACKWALK literally to ~/.mozbuild/minidump_stackwalk/minidump_stackwalk ? That would be the problem. ~ is not expanded in environment variables. Also, you don't need to set this because it will be found automatically.

Comment 3

[Dave Townsend [:mossop]]

(In reply to Alex Hochheiden [:ahochheiden] from comment #1)

Hey Dave,

I just tried running ./mach bootstrap --no-system-changes and minidump-stackwalk installed correctly on both Windows10 and Ubuntu.

I'm running macOS on a 2021 MacBook Pro (M1 Max).

I'm not sure what test you're running, but could you confirm that a ./mozbuild/minidump-stackwalk/ directory doesn't exist for you?

Nothing that looks related to minidump or stackwalk appears in .mozbuild.

I'm thinking it might be a difference between the - and _ in what's expected in what you're running versus what's actually there in the ./mozbuild directory.

If that's not the case (And no minidump stackwalk directory of any kind exists), could you delete the ./mozbuild/toolchains/ directory and re-run the ./mach bootstrap --no-system-changes command and paste the output here? Also, what operating system are you on?

trunk$ rm -rf ~/.mozbuild/toolchains/
trunk$ mach bootstrap --no-system-changes

Note on Artifact Mode:

Artifact builds download prebuilt C++ components rather than building
them locally. Artifact builds are faster!

Artifact builds are recommended for people working on Firefox or
Firefox for Android frontends, or the GeckoView Java API. They are unsuitable
for those working on C++ code. For more information see:
https://firefox-source-docs.mozilla.org/contributing/build/artifact_builds.html.

Please choose the version of Firefox you want to build (see note above):
  1. Firefox for Desktop Artifact Mode [default]
  2. Firefox for Desktop
  3. GeckoView/Firefox for Android Artifact Mode
  4. GeckoView/Firefox for Android
  5. SpiderMonkey JavaScript engine
Your choice: 2
Requirement already satisfied: glean-sdk==44.1.1 in /Users/dave/.mozbuild/srcdirs/trunk-d2ed815e765d/_virtualenvs/mach/lib/python3.9/site-packages (44.1.1)
Requirement already satisfied: glean-parser==5.0.1 in /Users/dave/.mozbuild/srcdirs/trunk-d2ed815e765d/_virtualenvs/mach/lib/python3.9/site-packages (from glean-sdk==44.1.1) (5.0.1)
Requirement already satisfied: cffi>=1.13.0 in /Users/dave/.mozbuild/srcdirs/trunk-d2ed815e765d/_virtualenvs/mach/lib/python3.9/site-packages (from glean-sdk==44.1.1) (1.15.0)
Requirement already satisfied: Click>=7 in ./third_party/python/click (from glean-parser==5.0.1->glean-sdk==44.1.1) (7.1.2)
Requirement already satisfied: appdirs>=1.4 in ./third_party/python/appdirs (from glean-parser==5.0.1->glean-sdk==44.1.1) (1.4.4)
Requirement already satisfied: jsonschema>=3.0.2 in ./third_party/python/jsonschema (from glean-parser==5.0.1->glean-sdk==44.1.1) (3.2.0)
Requirement already satisfied: Jinja2>=2.10.1 in ./third_party/python/Jinja2 (from glean-parser==5.0.1->glean-sdk==44.1.1) (2.11.3)
Requirement already satisfied: yamllint>=1.18.0 in ./third_party/python/yamllint (from glean-parser==5.0.1->glean-sdk==44.1.1) (1.23.0)
Requirement already satisfied: diskcache>=4 in ./third_party/python/diskcache (from glean-parser==5.0.1->glean-sdk==44.1.1) (4.1.0)
Requirement already satisfied: PyYAML>=5.3.1 in ./third_party/python/PyYAML/lib3 (from glean-parser==5.0.1->glean-sdk==44.1.1) (5.4.1)
Requirement already satisfied: pycparser in /Users/dave/.mozbuild/srcdirs/trunk-d2ed815e765d/_virtualenvs/mach/lib/python3.9/site-packages (from cffi>=1.13.0->glean-sdk==44.1.1) (2.21)
Requirement already satisfied: MarkupSafe>=0.23 in ./third_party/python/MarkupSafe/src (from Jinja2>=2.10.1->glean-parser==5.0.1->glean-sdk==44.1.1) (1.1.1)
Requirement already satisfied: pyrsistent>=0.14.0 in ./third_party/python/pyrsistent (from jsonschema>=3.0.2->glean-parser==5.0.1->glean-sdk==44.1.1) (0.16.0)
Requirement already satisfied: six>=1.11.0 in ./third_party/python/six (from jsonschema>=3.0.2->glean-parser==5.0.1->glean-sdk==44.1.1) (1.13.0)
Requirement already satisfied: setuptools in ./third_party/python/setuptools (from jsonschema>=3.0.2->glean-parser==5.0.1->glean-sdk==44.1.1) (51.2.0)
Requirement already satisfied: attrs>=17.4.0 in ./third_party/python/attrs (from jsonschema>=3.0.2->glean-parser==5.0.1->glean-sdk==44.1.1) (19.2.0)
Requirement already satisfied: pathspec>=0.5.3 in ./third_party/python/pathspec (from yamllint>=1.18.0->glean-parser==5.0.1->glean-sdk==44.1.1) (0.9.0)
Requirement already satisfied: psutil<=5.8.0,>=5.4.2 in /Users/dave/.mozbuild/srcdirs/trunk-d2ed815e765d/_virtualenvs/mach/lib/python3.9/site-packages (5.8.0)
Requirement already satisfied: zstandard<=0.17.0,>=0.11.1 in /Users/dave/.mozbuild/srcdirs/trunk-d2ed815e765d/_virtualenvs/mach/lib/python3.9/site-packages (0.17.0)

(In reply to Mike Hommey [:glandium] from comment #2)

Have you set MINIDUMP_STACKWALK literally to ~/.mozbuild/minidump_stackwalk/minidump_stackwalk ? That would be the problem. ~ is not expanded in environment variables. Also, you don't need to set this because it will be found automatically.

Looks like I was (did that used to be necessary?) however after removing it nothing appears to have improved though the error message has changed to:

MINIDUMP_STACKWALK binary not found: /Users/dave/.mozbuild/minidump_stackwalk/minidump_stackwalk. Use mach bootstrap --no-system-changes to install minidump-stackwalk.

Comment 4

[Mike Hommey [:glandium]]

Do you have something in /Users/date/.mozbuild/minidump-stackwalk? (with -, not _)

Comment 5

[Dave Townsend [:mossop]]

(In reply to Mike Hommey [:glandium] from comment #4)

Do you have something in /Users/date/.mozbuild/minidump-stackwalk? (with -, not _)

Everything in ~/.mozbuild:

_virtualenvs
cache
cbindgen
clang
clang-tools
dump_syms
fix-stacks
fzf
gecko-strings
glean
indices
machrc
moz-phab
node
package-frontend
srcdirs
sysroot-wasm32-wasi
version-control-tools

Comment 6

[Dave Townsend [:mossop]]

Attachment: Bug 1772808: Install minidump-stackwalk binaries on arm64 macOS. r=glandium

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39eee25de879
Install minidump-stackwalk binaries on arm64 macOS. r=glandium DONTBUILD

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/39eee25de879