1772891 - Default icon color incorrectly displayed as black on color picker button in folder properties

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P3)

Description

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

Default folder icon colors are not displayed in the preferences window.

STR:
0. Thunderbird 102.0b2, clean profile

1. Switch from the new account tab to the main tab
2. Create a new feed account with default settings to make the folder panel visible
3. Right-click on the feed account and add a new folder with any name
4. Right-click on the new folder and select the last item from the context menu (likely: "Preferences", but I'm not on an en-US locale while reporting this)

Expected:
The preferences window displays the same orange symbol color the folder is displayed at in the folder panel.

Actual:
The preferences window displays a dark blue symbol color (changing the color reveals that it is a custom color; changing the color to any other setting does work as expected).

Comment 1

[Alessandro Castellani [:aleca]]

Thanks for opening this bug.
For some context, this happens because I originally set the default folder color as a static value.
https://searchfox.org/comm-central/search?q=var+kDefaultColor&path=&case=true&regexp=false

This doesn't obviously work anymore, and the default color (non customized) of a folder will need to be fetched when the dialog loads.

Comment 3

[Alessandro Castellani [:aleca]]

Assigning this to Micah if he wants to take a stab at this issue.
This is mostly JavaScript with some annoying complications in terms of getting the actual color of the icon from the DOM.

Comment 5

[Thomas D. (:thomas8)]

Severity N/A is reserved for reports of type enhancement or task, so the lowest possible severity for a bug is S4.
P4 should suffice for this cosmetic issue.

Comment 6

[Thomas D. (:thomas8)]

Attachment: Screenshot: Default folder color of Sent Mail folder is green, but displays as black in folder properties

STR

• Right-click on any folder in 3-pane folder pane whose color still uses default settings (not customized) - best seen on custom folders added by user.
• Choose Properties from folder context menu
• Check the color displayed on the color picker button labeled Icon color: and compare with the actual folder color

Actual

• Color picker button incorrectly displays the color black, regardless of the actual default folder color

Expected

• Color picker button to display the actual default folder color used (as it does after customizing the color).

Comment 7

[Alessandro Castellani [:aleca]]

Thanks for the STR.
P3 is considered Backlog, while P4 is reserved for website issues: https://firefox-source-docs.mozilla.org/bug-mgmt/guides/priority.html

Comment 8

[[e-mail]]

Attachment: Bug 1772891 - Set correct default folder colors. r=aleca

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/49f98461dd1b
Set correct default folder colors. r=aleca

Comment 10

[Magnus Melin [:mkmelin]]

Attachment: Bug 1772891 - follow-up - set styles when dialog loaded. r=aleca

It currently works by luck (found this issue when testing if I could drop the bug 1752288 hack from the xhtml file.)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1f623a259dc6
follow-up - set styles when dialog loaded. r=aleca

Comment 12

[[e-mail]]

Attachment: Bug 1772891 - follow-up - set virtual folder styles when dialog loaded. r=aleca

Comment 13

[Alessandro Castellani [:aleca]]

Temporarily reopening this for a tiny follow up.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f141650585fb
follow-up - set virtual folder styles when dialog loaded. r=aleca