Closed Bug 1772911 Opened 2 years ago Closed 1 year ago

Improve the thread summary header panel style

Categories

(Thunderbird :: Toolbars and Tabs, enhancement)

enhancement

Tracking

(thunderbird102? fixed)

RESOLVED FIXED
103 Branch
Tracking Status
thunderbird102 ? fixed

People

(Reporter: aleca, Assigned: aleca)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1556261 introduced some nice customization on the message header.
Now we need to see if we can make the thread summary header follow the same customization, as well as fixing some alignment and spacing issues.

Action plan for this bug:

  • Better align the buttons in the header area and let them stack naturally. DONE
  • Use the same visual style of the message header buttons. DONE
  • Header customization of buttons should affect the buttons in the thread header.
Status: NEW → ASSIGNED

Would it make sense to dupe the old bug 519671 to this one? My WIP patch over there is terribly out of date, and wouldn't work in this new, less XUL-y future we're living in now.

Good call, thanks for the heads up, I missed that bug.

Target Milestone: --- → 103 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/82071b51fb0e
Better align toolbar buttons in thread summary header panel. r=Paenglab

(In reply to Alessandro Castellani [:aleca] from comment #0)

Use the same visual style of the message header buttons (maybe create a buttons.css file to share across windows).

Richard, would you be interested in taking a stab at this?
I trust you more than myself in handling shared button styles and clean up the CSS.

Flags: needinfo?(richard.marti)
Flags: needinfo?(richard.marti)

Comment on attachment 9279942 [details]
Bug 1772911 - Better align toolbar buttons in thread summary header panel. r=Paenglab

[Approval Request Comment]
Regression caused by (bug #): bug 1556261
User impact if declined: Wrong alignment and style of the multimessage header buttons
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9279942 - Flags: approval-comm-beta?

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/2b344cea5279
Use the header pane colors for the multimessage header pane. r=aleca

Since the multimessage view is inside a browser, applying the customization of the single message is complicated for no real reason.
Let's defer updating this after 102, where we will most likely rebuild this from scratch and make it more sane.

Comment on attachment 9280486 [details]
Bug 1772911 - Use the header pane colors for the multimessage header pane. r=aleca

[Approval Request Comment]
User impact if declined: inconsistent style of the multimessage pane
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9280486 - Flags: approval-comm-beta?

Comment on attachment 9280486 [details]
Bug 1772911 - Use the header pane colors for the multimessage header pane. r=aleca

[Triage Comment]
Approved for beta

Attachment #9280486 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9279942 [details]
Bug 1772911 - Better align toolbar buttons in thread summary header panel. r=Paenglab

[Triage Comment]
Approved for beta

Attachment #9279942 - Flags: approval-comm-beta? → approval-comm-beta+

Closing this since the supernova effort will change things around a bit after 115

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: leave-open
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: