Closed
Bug 1772930
Opened 2 years ago
Closed 1 year ago
Remove osfile.jsm usage from toolkit/components/downloads/
Categories
(Toolkit Graveyard :: OS.File, task, P3)
Toolkit Graveyard
OS.File
Tracking
(firefox109 fixed)
RESOLVED
FIXED
109 Branch
Tracking | Status | |
---|---|---|
firefox109 | --- | fixed |
People
(Reporter: barret, Assigned: barret)
References
Details
Attachments
(2 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
Bug 1772930 - Return NS_ERROR_FILE_ALREADY_EXISTS when refusing to overwrite files in IOUtils r?nika
48 bytes,
text/x-phabricator-request
|
Details | Review |
Assignee | ||
Updated•2 years ago
|
Assignee: nobody → brennie
Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Attachment #9292199 -
Attachment description: Bug 1772930 - Port osfile.jsm to IOUtils in toolkit/components/downloads/ r?gijs → WIP: Bug 1772930 - Port osfile.jsm to IOUtils in toolkit/components/downloads/ r?gijs
Updated•1 year ago
|
Attachment #9292199 -
Attachment description: WIP: Bug 1772930 - Port osfile.jsm to IOUtils in toolkit/components/downloads/ r?gijs → Bug 1772930 - Port osfile.jsm to IOUtils in toolkit/components/downloads/ r?gijs
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/289203a06952 Port osfile.jsm to IOUtils in toolkit/components/downloads/ r=Gijs
Comment 3•1 year ago
|
||
Backed out for causing mochitest failures in dom/system/tests/ioutils/test_ioutils_read_write.html
Backout link: https://hg.mozilla.org/integration/autoland/rev/53d3134566d8bd4c597c403f82d223bc110aee1a
TEST-UNEXPECTED-FAIL | dom/system/tests/ioutils/test_ioutils_read_write.html | TypeError: [...] is not a function - Should not throw any errors
Flags: needinfo?(brennie)
Assignee | ||
Updated•1 year ago
|
Flags: needinfo?(brennie)
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/21b10bf50941 Port osfile.jsm to IOUtils in toolkit/components/downloads/ r=Gijs
Comment 5•1 year ago
•
|
||
Backed out for causing multiple failures
Push with failures - xpcshell // Failure log - xpcshell
Push with failures 1 - bc // Failure log 1 - bc
Flags: needinfo?(brennie)
Comment 6•1 year ago
|
||
I noticed one mistake in common_test_Download.js line 407
await PathUtils.remove(targetFile.path);
It should be IOUtils.remove
instead.
Assignee | ||
Updated•1 year ago
|
Flags: needinfo?(brennie)
Assignee | ||
Comment 7•1 year ago
|
||
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7e712d8f5d3e Return NS_ERROR_FILE_ALREADY_EXISTS when refusing to overwrite files in IOUtils r=nika https://hg.mozilla.org/integration/autoland/rev/c194d5143ed4 Port osfile.jsm to IOUtils in toolkit/components/downloads/ r=Gijs
Comment 9•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7e712d8f5d3e
https://hg.mozilla.org/mozilla-central/rev/c194d5143ed4
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox109:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
Updated•11 months ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•