Closed Bug 1772930 Opened 2 years ago Closed 1 year ago

Remove osfile.jsm usage from toolkit/components/downloads/

Categories

(Toolkit Graveyard :: OS.File, task, P3)

Tracking

(firefox109 fixed)

RESOLVED FIXED
109 Branch
Tracking Status
firefox109 --- fixed

People

(Reporter: barret, Assigned: barret)

References

Details

Attachments

(2 files)

Assignee: nobody → brennie
Attachment #9292199 - Attachment description: Bug 1772930 - Port osfile.jsm to IOUtils in toolkit/components/downloads/ r?gijs → WIP: Bug 1772930 - Port osfile.jsm to IOUtils in toolkit/components/downloads/ r?gijs
Depends on: 1788997
Attachment #9292199 - Attachment description: WIP: Bug 1772930 - Port osfile.jsm to IOUtils in toolkit/components/downloads/ r?gijs → Bug 1772930 - Port osfile.jsm to IOUtils in toolkit/components/downloads/ r?gijs
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/289203a06952
Port osfile.jsm to IOUtils in toolkit/components/downloads/ r=Gijs

Backed out for causing mochitest failures in dom/system/tests/ioutils/test_ioutils_read_write.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/53d3134566d8bd4c597c403f82d223bc110aee1a

Push with failures

Failure log

TEST-UNEXPECTED-FAIL | dom/system/tests/ioutils/test_ioutils_read_write.html | TypeError: [...] is not a function - Should not throw any errors
Flags: needinfo?(brennie)
Flags: needinfo?(brennie)
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/21b10bf50941
Port osfile.jsm to IOUtils in toolkit/components/downloads/ r=Gijs

I noticed one mistake in common_test_Download.js line 407

await PathUtils.remove(targetFile.path);

It should be IOUtils.remove instead.

Flags: needinfo?(brennie)
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7e712d8f5d3e
Return NS_ERROR_FILE_ALREADY_EXISTS when refusing to overwrite files in IOUtils r=nika
https://hg.mozilla.org/integration/autoland/rev/c194d5143ed4
Port osfile.jsm to IOUtils in toolkit/components/downloads/ r=Gijs
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch
See Also: → 1802068
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: