1773088 - Stop requiring specific actors to serialize Blobs over IPC

Status: RESOLVED FIXED

(Core :: IPC, task)

Description

[Nika Layzell [:nika] (ni? for response)]

Since bug 1754004 the serialization of Blobs over IPC no longer requires specific actors to be used. This makes a lot of the complexity around the serialization APIs no longer necessary. This bug tracks removing the unnecessary complexity in these APIs.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1773088 - Part 1: Stop requiring an actor to serialize blobs over IPC, r=asuth

This does a somewhat-shallow removal of the argument from the implementation
and all call-sites. Removing it from StructuredCloneData's serialization is
handled in the next part, as it is more widely used and complex.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1773088 - Part 2: Stop requiring an actor to serialize StructuredCloneData over IPC, r=asuth

This is largely a straightforward find and replace of various methods, with the
unnecessary arguments removed and compiler errors fixed.

Depends on D148531

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1773088 - Part 3: Remove StealFromAndBuildClonedMessageData, r=asuth

This API should no longer be necessary, as there's nothing tied to a specific
actor in the serialized IPCBlob form any longer, so the value can be directly
transferred without special handling or re-serialization.

Depends on D148532

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ce8e9ab36a6
Part 1: Stop requiring an actor to serialize blobs over IPC, r=asuth
https://hg.mozilla.org/integration/autoland/rev/c3bcae27c660
Part 2: Stop requiring an actor to serialize StructuredCloneData over IPC, r=asuth
https://hg.mozilla.org/integration/autoland/rev/9da38873f110
Part 3: Remove StealFromAndBuildClonedMessageData, r=asuth

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2ce8e9ab36a6
https://hg.mozilla.org/mozilla-central/rev/c3bcae27c660
https://hg.mozilla.org/mozilla-central/rev/9da38873f110