Closed Bug 1773124 Opened 2 years ago Closed 2 years ago

Make devtools/shared/natural-sort.js easier to read

Categories

(DevTools :: Storage Inspector, task)

task

Tracking

(firefox103 fixed)

RESOLVED FIXED
103 Branch
Tracking Status
firefox103 --- fixed

People

(Reporter: miker, Assigned: miker)

References

Details

Attachments

(1 file)

The file is a well known natural sort method but is unfortunately very difficult to read. This is a problem because it makes it difficult to make effective changes to the code and is particularly frightening to new contributors.

It just needs a little tidying and easier to understand variable names assigning... it currently contains variable names like oFxNcL and oFyNcL, which are not very meaningful.

Pushed by michael@ratcliffefamily.org:
https://hg.mozilla.org/integration/autoland/rev/0e42a49fee97
Make devtools/shared/natural-sort.js easier to read r=devtools-reviewers,jdescottes
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: