Closed Bug 1773154 Opened 2 years ago Closed 2 years ago

Reduce the number of scheduled sync calls in sync-after-tab-change

Categories

(Firefox :: Sync, task)

task

Tracking

()

RESOLVED FIXED
103 Branch
Tracking Status
firefox103 --- fixed

People

(Reporter: skhamis, Assigned: skhamis)

References

Details

(Whiteboard: [fxsync-tc])

Attachments

(1 file)

Doing some deep dive into testing how often we're scheduling syncs, I believe there is some room for improvements to help reduce the amount of times we're scheduling sync (note the upper limit is still 5s when the sync after tab change experiment is enabled)

Optimizations planned:

  1. On TabOpen, TabClose, TabSelect: We should only schedule a sync if it's a supported scheme https://searchfox.org/mozilla-central/source/services/sync/modules/engines/tabs.js#58

  2. We're taking advantage of some flags but don't detect when the user is reloading - https://searchfox.org/mozilla-central/source/uriloader/base/nsIWebProgressListener.idl#460

  • We shouldn't resync after a reload
Pushed by skhamis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b711425de7dc
Reduce number of scheduled sync calls in sync-after-tab-change r=markh,Gijs
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: