Closed Bug 1773174 Opened 6 months ago Closed 6 months ago

Rename all .js files that use EXPORTED_SYMBOLS to .jsm in toolkit/

Categories

(Toolkit :: General, task)

task

Tracking

()

RESOLVED FIXED
103 Branch
Tracking Status
firefox103 --- fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 7 obsolete files)

+++ This bug was initially created as a clone of Bug #1773169 +++

To make the JSM-to-ESM migration easier, and also make the shim in bug 1766761 work, it's better using *.jsm extension consistently for all JSMs.

Given AddonManager.jsm exists, we cannot rename addonManager.js to
addonManager.jsm, given it conflicts on case-insensitive file system.

Depends on D148602

Attachment #9280173 - Attachment description: Bug 1773174 - Part 7: Use .jsm extension for JSMs in toolkit/modules/third_party/jsesc/. r?florian → Bug 1773174 - Part 7: Use .jsm extension for JSMs in toolkit/modules/third_party/jsesc/. r?florian!
Attachment #9280167 - Attachment description: Bug 1773174 - Part 1: Use .jsm extension for JSMs in toolkit/components/certviewer/. r?keeler → Bug 1773174 - Part 1: Use .jsm extension for JSMs in toolkit/components/certviewer/. r?keeler!
Attachment #9280167 - Attachment is obsolete: true
Attachment #9280168 - Attachment is obsolete: true
Attachment #9280169 - Attachment is obsolete: true
Attachment #9280170 - Attachment is obsolete: true
Attachment #9280171 - Attachment is obsolete: true
Attachment #9280172 - Attachment is obsolete: true
Attachment #9280173 - Attachment is obsolete: true
Attachment #9280174 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → WONTFIX
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Attachment #9280167 - Attachment is obsolete: false
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/5d24f102662e
Part 1: Use .jsm extension for JSMs in toolkit/components/certviewer/. r=keeler
Status: REOPENED → RESOLVED
Closed: 6 months ago6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/51922775c5fc
adjust Thunderbird for asn1js_bundle.js renaming. rs=bustage-fix DONTBUILD

I'm a little confused about the state of this bug - are we only renaming the certviewer stuff now, or are we still intending to rename all the other ones? I don't think most of the other JSMs are used that much outside of m-c but perhaps my lack of visibility means I'm wrong about that?

Flags: needinfo?(arai.unmht)

For me, the biggest reason of the rename was to make these files target of the shim added by bug 1766761 (that supported only *.jsm extension),
so that in-tree migration becomes easier.

Then, I overlooked about the out-of-tree consumer, at least for services/, as pointed out in bug 1609269 comment #8,
and that requires supporting *.js in the shim, and that at the same time requires recognizing .jsm.js separately.
And those 2 are supported in bug 1773603.

Now that *.js and .jsm.js are supported in the shim, there's not much reason to rename all those files immediately.
I still prefer renaming them, but leaving them as is is safer option.
So, I tentatively abandoned those patches. If there's any file that's definitely not referred from out-of-tree, I'll revive the patch.

Flags: needinfo?(arai.unmht)
You need to log in before you can comment on or make changes to this bug.