1773174 - Rename all .js files that use EXPORTED_SYMBOLS to .jsm in toolkit/

Status: RESOLVED FIXED

(Toolkit :: General, task)

Description

[Tooru Fujisawa [:arai]]

+++ This bug was initially created as a clone of Bug #1773169 +++

To make the JSM-to-ESM migration easier, and also make the shim in bug 1766761 work, it's better using *.jsm extension consistently for all JSMs.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1773174 - Part 1: Use .jsm extension for JSMs in toolkit/components/certviewer/. r?keeler!

Depends on D148595

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1773174 - Part 2: Use .jsm extension for JSMs in toolkit/components/lz4/. r?florian

Depends on D148596

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1773174 - Part 3: Use .jsm extension for JSMs in toolkit/components/normandy/. r?barret

Depends on D148597

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1773174 - Part 4: Use .jsm extension for JSMs in toolkit/components/passwordmgr/. r?MattN

Depends on D148598

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1773174 - Part 5: Use .jsm extension for JSMs in toolkit/components/pdfjs/. r?calixte

Depends on D148599

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1773174 - Part 6: Use .jsm extension for JSMs in toolkit/components/utils/. r?Gijs

Depends on D148600

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1773174 - Part 7: Use .jsm extension for JSMs in toolkit/modules/third_party/jsesc/. r?florian!

Depends on D148601

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1773174 - Part 8: Rename toolkit/mozapps/extensions/addonManager.js to addonManagerComponent.jsm. r?mossop

Given AddonManager.jsm exists, we cannot rename addonManager.js to
addonManager.jsm, given it conflicts on case-insensitive file system.

Depends on D148602

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d24f102662e
Part 1: Use .jsm extension for JSMs in toolkit/components/certviewer/. r=keeler

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5d24f102662e

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/51922775c5fc
adjust Thunderbird for asn1js_bundle.js renaming. rs=bustage-fix DONTBUILD

Comment 12

[:Gijs (he/him)]

I'm a little confused about the state of this bug - are we only renaming the certviewer stuff now, or are we still intending to rename all the other ones? I don't think most of the other JSMs are used that much outside of m-c but perhaps my lack of visibility means I'm wrong about that?

Comment 13

[Tooru Fujisawa [:arai]]

For me, the biggest reason of the rename was to make these files target of the shim added by bug 1766761 (that supported only *.jsm extension),
so that in-tree migration becomes easier.

Then, I overlooked about the out-of-tree consumer, at least for services/, as pointed out in bug 1609269 comment #8,
and that requires supporting *.js in the shim, and that at the same time requires recognizing .jsm.js separately.
And those 2 are supported in bug 1773603.

Now that *.js and .jsm.js are supported in the shim, there's not much reason to rename all those files immediately.
I still prefer renaming them, but leaving them as is is safer option.
So, I tentatively abandoned those patches. If there's any file that's definitely not referred from out-of-tree, I'll revive the patch.