Closed Bug 1773201 Opened 2 years ago Closed 2 years ago

Show contact photos in the Address Book contact list

Categories

(Thunderbird :: Address Book, enhancement)

enhancement

Tracking

(thunderbird102 fixed)

RESOLVED FIXED
103 Branch
Tracking Status
thunderbird102 --- fixed

People

(Reporter: darktrojan, Assigned: aleca)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

We want to display contacts' photos or their initial in the Address Book list, like we do in the message header. First we should refactor the code which finds the URL to the photo, so that we can stop copying it around wherever we use it.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
Keywords: leave-open
Target Milestone: --- → 103 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/007647012d92
Refactor code for finding a contact's photo. r=aleca

Comment on attachment 9280181 [details]
Bug 1773201 - Refactor code for finding a contact's photo. r=aleca

[Approval Request Comment]
User impact if declined: Unnoticeable for the users, it's needed for development and easier future uplifts.
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9280181 - Flags: approval-comm-beta?

Comment on attachment 9280181 [details]
Bug 1773201 - Refactor code for finding a contact's photo. r=aleca

[Triage Comment]
Approved for beta

Attachment #9280181 - Flags: approval-comm-beta? → approval-comm-beta+
Assignee: geoff → alessandro

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/00936977702d
Improve contacts list UI and show profile picture if available. r=darktrojan,Paenglab

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Some test failures from this, at least
comm/mailnews/addrbook/test/unit/test_jsaddrbook.js
comm/mailnews/addrbook/test/unit/test_addrBookCard.js

"bundle" is null which used to be a thing: https://hg.mozilla.org/comm-central/diff/00936977702d70732f9aeca7e1e03e8baf78b63b/mailnews/addrbook/modules/AddrBookCard.jsm#l1.25

Flags: needinfo?(alessandro)
Attachment #9281244 - Attachment description: Bug 1773201 - Fix handling of missing bundle in Address Book generateName method. r=#thunderbird-reviewers → Bug 1773201 - Fix handling of missing bundle in Address Book generateName method. r=freaktechnik

Reopening due to test failures.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/550af433f8ec
Fix handling of missing bundle in Address Book generateName method. r=freaktechnik

Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Regressions: 1774400
No longer regressions: 1774400

Comment on attachment 9280551 [details]
Bug 1773201 - Improve contacts list UI and show profile picture if available. r=darktrojan,Paenglab

[Approval Request Comment]
User impact if declined: Simple UI improvements for the contacts list
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9280551 - Flags: approval-comm-beta?

Comment on attachment 9281244 [details]
Bug 1773201 - Fix handling of missing bundle in Address Book generateName method. r=freaktechnik

[Approval Request Comment]
User impact if declined: Missing display name and proper first/last name formatting
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9281244 - Flags: approval-comm-beta?

Comment on attachment 9280551 [details]
Bug 1773201 - Improve contacts list UI and show profile picture if available. r=darktrojan,Paenglab

[Triage Comment]
Approved for beta

Attachment #9280551 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9281244 [details]
Bug 1773201 - Fix handling of missing bundle in Address Book generateName method. r=freaktechnik

[Triage Comment]
Approved for beta

Attachment #9281244 - Flags: approval-comm-beta? → approval-comm-beta+
Regressions: 1774386
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: