177333 - --enable-plaintext-editor-only no longer build

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[TVL]

--enable-plaintext-editor-only no longer builds on the trunk.

c++ -I/usr/X11R6/include -frtti -fno-exceptions -Wall -Wconversion
-Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy
-pedantic -Wno-long-long -pthread -pipe  -DDEBUG -D_DEBUG -DDEBUG_tvl -DTRACING
-g -fno-inline -fPIC -shared -Wl,-h -Wl,libeditor.so -o libeditor.so 
nsTextEditorReg.o             -Wl,--whole-archive  ../text/libtexteditor_s.a
../base/libeditorbase_s.a  -Wl,--no-whole-archive 
../../../dist/lib/libunicharutil_s.a -L../../../dist/bin -lxpcom  -liberty
-liberty -L../../../dist/bin -L/src/local/Mozilla/debug/dist/lib -lplds4 -lplc4
-lnspr4 -lpthread -ldl  -L../../../dist/bin -lmozjs   -Wl,-Bsymbolic -ldl -lm
nsTextEditorReg.o: In function `nsEditorServiceConstructor(nsISupports *, nsID
const &, void **)':
/src/local/Mozilla/../../../mozilla/editor/libeditor/build/nsTextEditorReg.cpp:54:
undefined reference to `nsEditorService::nsEditorService(void)'
collect2: ld returned 1 exit status
make[6]: *** [libeditor.so] Error 1
make[6]: Leaving directory `/src/local/Mozilla/debug/editor/libeditor/build'

Comment 1

[kinmoz]

This looks like fallout from bryner's checkin for bug 170136 (Configure flag to
disable composer).

I think he may need to make the same changes he made to 

  editor/libeditor/build/nsEditorRegistration.cpp

to 

  editor/libeditor/build/nsTextEditorReg.cpp

Comment 2

[Brian Ryner (not reading)]

Hm, I know --enable-plaintext-editor-only builds fine in conjunction with
--disable-composer, but I guess it may have broken if used separately.

Comment 3

[hacker formerly known as [e-mail]]

Do we really need both options?  I thought that disabling the composer would
also disable the html editing features as they aren't needed/used without the
composer. 

Comment 4

[kinmoz]

I think what was checked in merely prevented the composer dll and chrome from
being built, so I'm assuming that whatever builds that are relying on this
disable composer option, are still building the editor-core library with the
HTML code enabled.

Some embedders want the minimal amount of editor-core code necessary to keep
text widgets in the browser working. That's what the plaintext-only option is
about. This plaintext-only option also reduces the editor-core dll by about half.

Comment 5

[Brian Ryner (not reading)]

Attachment: patch

Comment 6

[kinmoz]

Comment on attachment 104574 [details] [diff] [review]
patch

sr=[e-mail]

Comment 7

[hacker formerly known as [e-mail]]

Comment on attachment 104574 [details] [diff] [review]
patch

r=cls

Comment 8

[Brian Ryner (not reading)]

Oops, sorry I didn't check this in yet.  --enable-plaintext-editor-only broke
again today, but in a different way.  I have a new patch that addresses both
problems.  I completely removed nsTextEditorReg.cpp and just added #ifdefs to
nsEditorRegistration.cpp.  This seems like a better solution anyway, and more
maintainable.

Comment 9

[Brian Ryner (not reading)]

Attachment: patch v2

Comment 10

[Brian Ryner (not reading)]

Attachment: patch #2 with removal of nsTextEditorReg.cpp included

Comment 11

[mjudge]

Comment on attachment 106072 [details] [diff] [review]
patch #2 with removal of nsTextEditorReg.cpp included

r=mjudge

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 106072 [details] [diff] [review]
patch #2 with removal of nsTextEditorReg.cpp included

sr=[e-mail]

Comment 13

[Brian Ryner (not reading)]

Hm, I guess there need to be some mac build changes to go with this. Too tired
to do that tonight.

Comment 14

[Brian Ryner (not reading)]

Attachment: mac build change

I think this is all that we need for Mac.

Comment 15

[Joe Francis]

That seems a bit unnatural to me.  MacEditorConfig.h is included when building
the plaintext-only editor as well.

Comment 16

[Brian Ryner (not reading)]

Attachment: patch #3

This leverages the already-existing #define on Mac.

Comment 17

[Joe Francis]

Attachment: mac editor project file changes

Some mac build help for bryner.  This patch changes the plaintext targets to
use the plaintext prefix files, which lights the MOZILLA_PLAINTEXT_EDITOR_ONLY
define.

Comment 18

[Simon Fraser [no longer active]]

Don't we need a new build option too?

Comment 19

[Brian Ryner (not reading)]

Attachment: new combined patch

Comment 20

[Joe Francis]

Comment on attachment 106159 [details] [diff] [review]
new combined patch

i built this on cfm mac, and tested the resulting lib with mozilla.  text
widgets work.

Comment 21

[Brian Ryner (not reading)]

checked in.

Comment 22

[sairuh (rarely reading bugmail)]

rs vrfy.