Closed Bug 1773335 Opened 2 years ago Closed 2 years ago

Remove uses of `cx->tempLifoAlloc()` from the Parser and HelperThreads

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
103 Branch
Tracking Status
firefox103 --- fixed

People

(Reporter: nbp, Assigned: bthrall)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently the parser makes use of cx->tempLifoAlloc() to allocate its AST and all temporary structures which are not part of its output. Using a LifoAlloc is fine, but relying strictly on the JSContext is a dependency that we want to remove.

We should remplace the cx->tempLifoAlloc() within the Parser by an argument which can either be coming from the JSContext, in case of main-thread parsing, or from a newly initialized LifoAlloc, in the case of the HelperThread.

See cx->tempLifoAlloc() references.

Assignee: nobody → bthrall
Attachment #9281236 - Attachment description: WIP: Bug 1773335 - Pass LifoAlloc to CompileGlobalScriptToStencil() as parameter r?arai → Bug 1773335 - Pass LifoAlloc to CompileGlobalScriptToStencil() as parameter r?arai
Blocks: 1774636
Pushed by bthrall@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b004f2382dc6 Pass LifoAlloc to CompileGlobalScriptToStencil() as parameter r=arai
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: