Closed
Bug 1773353
Opened 4 years ago
Closed 4 years ago
ResourceQueue::EvictAll and ::EvictBefore spams NS_WARN messages with an empty queue
Categories
(Core :: Audio/Video, defect, P3)
Tracking
()
RESOLVED
FIXED
103 Branch
| Tracking | Status | |
|---|---|---|
| firefox103 | --- | fixed |
People
(Reporter: bradwerth, Assigned: bradwerth)
Details
Attachments
(1 file)
An empty queue during EvictAll will result in a call for an out-of-bounds 0 index element from the nsDeque. Since EvictAll is called frequently, this can fill the console with NS_WARN messages.
|
Assignee | |
Comment 1•4 years ago
|
||
This early exit prevents a call to ResourceAt(0) on an empty queue. Such
a call emits an NS_WARN message. Since EvictAll can be called
frequently, these NS_WARN messages can fill up the console if the queue
remains empty.
|
||
Updated•4 years ago
|
Attachment #9280307 -
Attachment description: Bug 1773353: Prevent ResourceQueue::EvictAll from attempting to retrieve elements of an empty queue. → Bug 1773353: Prevent ResourceQueue::EvictAll and ::EvictBefore from attempting to retrieve elements of an empty queue.
|
|
Assignee | |
Updated•4 years ago
|
Summary: ResourceQueue::EvictAll from spams NS_WARN messages with an empty queue → ResourceQueue::EvictAll and ::EvictBefore spams NS_WARN messages with an empty queue
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2501a5ed77c
Prevent ResourceQueue::EvictAll and ::EvictBefore from attempting to retrieve elements of an empty queue. r=media-playback-reviewers,padenot
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox103:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•