1773459 - [wpt-sync] Sync PR 34358 - Avoid double flow thread insertion notification for ex-spanners.

Status: RESOLVED FIXED

(Core :: Layout: Columns, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 34358 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34358
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Avoid double flow thread insertion notification for ex-spanners.

We used to call FlowThreadDescendantWasInserted() for the same
descendant both via RemoveSpannerPlaceholderIfNoLongerValid() and
FlowThreadDescendantStyleDidChange(), causing DCHECK failures.

Skip the call to FlowThreadDescendantStyleDidChange() for spanners (and
ex-spanners). FlowThreadDescendantStyleDidChange() is expected to follow
a previous call to FlowThreadDescendantStyleWillChange(), but
FlowThreadDescendantStyleWillChange() will never be called for
spanners/ex-spanners, while, without this fix
FlowThreadDescendantStyleDidChange() would in fact be invoked for
ex-spanners (a spanner that's about to become regular column content),
which would trigger another FlowThreadDescendantWasInserted() in some
cases.

Bug: 1333166
Change-Id: I5b643df42987e9e8ef3abfa27c6d72535b66f091
Reviewed-on: https://chromium-review.googlesource.com/3695343
WPT-Export-Revision: 8e150a74777e9828695248057a682407d7b308da

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c35471b2cbd47467dea69db29abd226d82bcd77f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34e5aa8b350a
[wpt PR 34358] - Avoid double flow thread insertion notification for ex-spanners., a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/34e5aa8b350a