Change about:logins module files to use mjs extensions.
Categories
(Firefox :: about:logins, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox103 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
With the transition to using ES modules rather than JSMs getting started, we are now using the .mjs extension for those files.
I'd like to transition our content code that is using modules to use the .mjs extension as well - the primary gains of this are that we a) don't need to manually specify sourceType: module for ESLint, b) this gives a visual distinction to developers that the file is a module rather than a regular JavaScript file.
This bug is for the transition of the about:logins code.
|
Assignee | |
Comment 1•2 years ago
|
||
Depends on D148771
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ebc7b14f1ce5 Change about:logins module files to use mjs extensions. r=sgalich
|
||
Comment 3•2 years ago
|
||
Backed out 2 changesets (bug 1773469, bug 1773468) for causing browser-chrome failures in test/static/browser_all_files_referenced.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/4cd8570b0fd1ff8d2c4569199893c0a2e76afecf
INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 2, expected +0
|
||
Comment 4•2 years ago
|
||
I think we need changes to these lines https://searchfox.org/mozilla-central/source/browser/base/content/test/static/browser_all_files_referenced.js#657,671,710,831,982 and perhaps some more.
|
|
Assignee | |
Comment 5•2 years ago
|
||
Yeah, there's also something we need to add for handling imports, I think I've got a patch now, just testing it a bit more.
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fd010cc46357 Change about:logins module files to use mjs extensions. r=sgalich
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
Description
•