1773485 - Drop-down menus in dialog "Add a personal OpenPGP Key for ..." does not follow dark theme

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[australstrompetrel]

Attachment: TB new OpenPGP key.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

1. Open the OpenPGP Key Manager via menu "Tools"
2. Click on the menu "Generate" and "New Key Pair"
3. Click on the drop-down menu "Key expires in" or "Key type" or "Key size"

Happened in 102.0b4 (32-bit) under Windows 7.

Actual results:

The drop-down menus does not follow the dark theme.

Expected results:

The drop-down menus should follow the dark theme.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1773485 - Add contextMenu.css to more PGP key dialogs. r=aleca

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f2850a9816d0
Add contextMenu.css to more PGP key dialogs. r=aleca

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9280489 [details]
Bug 1773485 - Add contextMenu.css to more PGP key dialogs. r=aleca

[Approval Request Comment]
User impact if declined: on older Windows versions wrong popup colours on some PGP dialogs. Fixes also missed changes from bug 1768505
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9280489 [details]
Bug 1773485 - Add contextMenu.css to more PGP key dialogs. r=aleca

[Triage Comment]
Approved for beta

do you mean bug 1768505 or bug 1773525? for "we'd need to wait until the icon patch will be uplifted until we can uplift this one" ?

Comment 5

[Richard Marti (:Paenglab)]

I meant bug 1768505 attachment 9279293 [details] (Implement supernova icons in toolbars and main menu). It has approval, so no problem.

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 102.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/8e2c18bb0e61