1773490 - Spaces Toolbar overlaps Menu Bar on Win7/8.1

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[australstrompetrel]

Attachment: TB Spaces Toolbar.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

1. Show the Menu Bar via menu "View" - "Toolbars" - "Menu Bar"
2. Show the Spaces Toolbar via "View" - "Toolbars" - "Spaces Toolbar"

Happened in 102.0b4 (32-bit) under Windows 7.

Actual results:

The Spaces Toolbar overlap the Menu Bar (Menu "File").

Expected results:

The Spaces Toolbar should not overlap the Menu Bar (Menu "File").

Comment 1

[Richard Marti (:Paenglab)]

You're on Windows 10, correct? If yes, how do you move the menubar below the tabs? Through userChrome.css or an extension? Both ways aren't an issue of TB and should be fixed there and this bug should be closed as invalid.

Comment 2

[australstrompetrel]

No, it's on Windows 7. I write the bug report on a computer with Windows 10. But the defect happened on Windows 7. On Windows 10 the defect does not happened.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Bug 1773490 - [Windows 7 Aero/8.1] Don't apply the full negative margin to the menubar for the Spaces Toolbar. r=aleca

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/027dc1444ce1
[Windows 7 Aero/8.1] Don't apply the full negative margin to the menubar for the Spaces Toolbar. r=aleca

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9280696 [details]
Bug 1773490 - [Windows 7 Aero/8.1] Don't apply the full negative margin to the menubar for the Spaces Toolbar. r=aleca

[Approval Request Comment]
User impact if declined: on Windows 7 Aero and 8.1 hidden File menu when Spaces bar is shown
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 6

[Richard Marti (:Paenglab)]

This bug needs a second patch that adds an additional negative top margin to the Spaces bar when the menubar is shown. This needs to be done in a matchMedia("(-moz-windows-glass)") condition.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9280696 [details]
Bug 1773490 - [Windows 7 Aero/8.1] Don't apply the full negative margin to the menubar for the Spaces Toolbar. r=aleca

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 102.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/88a16c2012fd

Comment 9

[Thomas D. (:thomas8)]

(In reply to Richard Marti (:Paenglab) from comment #6)

This bug needs a second patch that adds an additional negative top margin to the Spaces bar when the menubar is shown. This needs to be done in a matchMedia("(-moz-windows-glass)") condition.

Richard - would you like to finish this off?

Comment 10

[Richard Marti (:Paenglab)]

If I knew how to do it I would have done it.

Comment 11

[Wayne Mery (:wsmwk)]

created bug 1833586 for comment 6