177351 - checksetup.pl tells about deleting templates in silent-running mode

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Dave Miller [:justdave]]

The checkin from bug 168191 has caused me to start receiving email from
landfill.bugzilla.org/bugzilla-tip on an hourly basis informing me that the
compiled templates are being deleted.

Output from checksetup.pl which happens every time you run it no matter what is
supposed to have "unless $silent" after it so it doesn't output in
silent-running mode (i.e. via a cron job).  The only output from checksetup.pl
in silent-running mode is supposed to be things the admin needs to know about
(i.e. changes to database structure, or something that requires input from the
admin before it can continue).

Comment 1

[Gervase Markham [:gerv]]

This whole "if $silent" thing is a nasty architecture anyway;

sub sprint {
  if (!$silent) {
    print @_;
  }
}

Then s/print/sprint/ everywhere would have been a much better solution. Seperate
logic from presentation :-)

Anyway, I guess we're stuck with it now. I'll whip up a patch.

Gerv

Comment 2

[Bradley Baetz (:bbaetz)]

Yeah, that patch was written before 'silent' mode, IIRC

Comment 3

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Simple one-line fix.

Gerv

Comment 4

[Dave Miller [:justdave]]

Comment on attachment 104610 [details] [diff] [review]
Patch v.1

2xr= justdave

Comment 5

[Gervase Markham [:gerv]]

Fixed.

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.201; previous revision: 1.200
done

Gerv