1773706 - Permafailing toolkit/mozapps/extensions/test/browser/browser_colorwaycloset_aboutaddons.js failures when Gecko 103 merges to Beta on 2022-06-27

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Natalia Csoregi [:nataliaCs]]

[Tracking Requested - why for this release]:

• Central-as-beta
• How to run these simulations
• Failure logs:
  • TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_colorwaycloset_aboutaddons.js | application terminated with exit code 2147483651
  • PROCESS-CRASH | toolkit/mozapps/extensions/test/browser/browser_colorwaycloset_aboutaddons.js | application crashed [@ CheckForBrokenChromeURL(nsILoadInfo*, nsIURI*)]

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1769147

Comment 2

[kpatenio]

Update: see comment 4

@lgreco left a comment in this patch that may explain the cause of the failures. A crash occurs when selecting the Try Colorways button - which the regressing bug modifies by opening the Colorway Closet modal that would show existing Colorway themes. This crash happens because a mock theme that we create during the test does not have an associated icon that we'd expect to show in the modal. Proposed solutions include ignoring the theme when an icon cannot be set (followed by an error log), or just not setting an icon at all if none is available. (firefox)

Comment 3

[kpatenio]

Attachment: WIP: Bug 1773706 - do not render Colorway in closet modal if there is no icon available. r=dao!

Comment 4

[kpatenio]

Ah... thinking about it now, the culprit is actually from failing to load resource:///modules/ColorwayClosetOpener.jsm since colorways is limited to Nightly builds (considering that firefoxview is also Nightly only - relevant since firefoxview is one entrypoint for the modal itself). The initially submitted WIP patch happens to be another issue related to the Colorway closet card in about:addons.

• colorways test set to nightly only
• firefoxview set to nightly only

Log:

[task 2022-06-10T14:21:07.350Z] 14:21:07     INFO - PROCESS-CRASH | toolkit/mozapps/extensions/test/browser/browser_colorwaycloset_aboutaddons.js | application crashed [@ CheckForBrokenChromeURL(nsILoadInfo*, nsIURI*)]
[task 2022-06-10T14:21:07.351Z] 14:21:07     INFO - Mozilla crash reason: Missing chrome or resource URLs: resource:///modules/ColorwayClosetOpener.jsm

Comment 5

[kpatenio]

Attachment: Bug 1773706 - run browser_colorwaycloset_aboutaddons.js for nightly only. r=dao!

Comment 6

[Phabricator Automation]

Comment on attachment 9280787 [details]
Bug 1773706 - run browser_colorwaycloset_aboutaddons.js for nightly only. r=dao!

Revision D148969 was moved to bug 1773800. Setting attachment 9280787 [details] to obsolete.

Comment 7

[Phabricator Automation]

Comment on attachment 9280748 [details]
WIP: Bug 1773706 - do not render Colorway in closet modal if there is no icon available. r=dao!

Revision D148951 was moved to bug 1773800. Setting attachment 9280748 [details] to obsolete.

Comment 8

[Cosmin Sabou [:CosminS]]

The patch here gets rid of the failures as in the test is no longer ran on beta and the fix from Bug 1773800 is not working under beta conditions https://bugzilla.mozilla.org/show_bug.cgi?id=1773800#c4

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2111b084edc0
run browser_colorwaycloset_aboutaddons.js for nightly only. r=dao

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/2111b084edc0

Comment 11

[Cristina Cozmuta (:CrissCozmuta)]

The patch has been verified in yesterday's beta-sim