Closed Bug 1773740 Opened 2 years ago Closed 2 years ago

Detect chrome script with .js by ChromeUtils uses

Categories

(Developer Infrastructure :: Lint and Formatting, task)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Type:
task

Tracking

(firefox104 fixed)

Status:
RESOLVED FIXED
Milestone:
104 Branch
Tracking Flags:
Tracking Status
firefox104 --- fixed

People

(Reporter: saschanaz, Assigned: saschanaz)

References

Details

Attachments

(4 files)

Bug 1773740 - Part 1: Refactor lazy.OS.File/Path detection for ESLint rules use-isInstance/reject-osfile.js r=standard8
48 bytes, text/x-phabricator-request
Details | Review
Bug 1773740 - Part 2: Only handle identifiers pointing to environment globals r=standard8
48 bytes, text/x-phabricator-request
Details | Review
Bug 1773740 - Part 3: Cover js files including ChromeUtils r=standard8
48 bytes, text/x-phabricator-request
Details | Review
Bug 1773740 - Part 4: Reapply `mach -l eslint --fix` with use-isInstance changes r=standard8
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Attachment #9280716 - Attachment description: WIP: Bug 1773740 - Part 1: Detect lazy.OS.File/Path from eslint rules → Bug 1773740 - Part 1: Detect lazy.OS.File/Path from eslint rules r=standard8
Attachment #9280717 - Attachment description: WIP: Bug 1773740 - Part 2: Better reference handling → Bug 1773740 - Part 2: Better reference handling r=standard8
Attachment #9280718 - Attachment description: WIP: Bug 1773740 - Part 3: Cover js files including ChromeUtils → Bug 1773740 - Part 3: Cover js files including ChromeUtils r=standard8
Attachment #9280719 - Attachment description: WIP: Bug 1773740 - Part 4: Apply autofix → Bug 1773740 - Part 4: Apply autofix r=standard8
Attachment #9280716 - Attachment description: Bug 1773740 - Part 1: Detect lazy.OS.File/Path from eslint rules r=standard8 → Bug 1773740 - Part 1: Refactor lazy.OS.File/Path detection r=standard8

Just to note I'm currently backlogged on reviews and other work, so I possibly won't get to this before the end of the week.

Got it, no hurry 👍

Attachment #9280716 - Attachment description: Bug 1773740 - Part 1: Refactor lazy.OS.File/Path detection r=standard8 → Bug 1773740 - Part 1: Refactor lazy.OS.File/Path detection for ESLint rules use-isInstance/reject-osfile.js r=standard8
Attachment #9280717 - Attachment description: Bug 1773740 - Part 2: Better reference handling r=standard8 → Bug 1773740 - Part 2: Only handle identifiers pointing to environment globals r=standard8
Attachment #9280719 - Attachment description: Bug 1773740 - Part 4: Apply autofix r=standard8 → Bug 1773740 - Part 4: Reapply `mach -l eslint --fix` with use-isInstance changes r=standard8

Note: Please hold off landing these changes until after the soft freeze finishes on Monday. Whilst I don't think they will cause issues, I think it would be better to let them soak for the full cycle, just in case.

Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b09a3e365881
Part 1: Refactor lazy.OS.File/Path detection for ESLint rules use-isInstance/reject-osfile.js r=Standard8
https://hg.mozilla.org/integration/autoland/rev/125034fa1eaa
Part 2: Only handle identifiers pointing to environment globals r=Standard8
https://hg.mozilla.org/integration/autoland/rev/0fc0aa357bec
Part 3: Cover js files including ChromeUtils r=Standard8
https://hg.mozilla.org/integration/autoland/rev/507b268dec95
Part 4: Reapply `mach -l eslint --fix` with use-isInstance changes r=Standard8
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/9932b93900d0
Port bug 1773740 - Run `mach -l eslint --fix` with use-isInstance changes. rs=linting
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/1f4babc93bd1
follow-up - Revert changes in WebExtensions tests. rs=bustage-fix
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: