1773746 - [wpt-sync] Sync PR 34376 - Reland "[FedCM] Make revoke test do actual network requests"

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 34376 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34376
Details from upstream follow.

Christian Biesinger <[e-mail]> wrote:

Reland "[FedCM] Make revoke test do actual network requests"

This reverts commit f5b6833a709e056c8cdf9555937207e24fb1efa4.

Reason for revert: Should work now that https://crrev.com/c/3696516 landed

Original change's description:

Revert "[FedCM] Make revoke test do actual network requests"

This reverts commit 6a575ea5afec3e47b3975f082cde49acf1c89063.

Reason for revert: This CL might cause test external/wpt/credential-management/fedcm-revoke.sub.https.html to be flaky.

Original change's description:

[FedCM] Make revoke test do actual network requests

Instead of using a mojo mock. This tests a lot more of our code.

Bug: 1309251
Change-Id: I079cbbf962ed8b95870bd51fdff35f6f37ca3974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3680732
Commit-Queue: Christian Biesinger \<[e-mail]>
Reviewed-by: Yi Gu \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1011646}

Bug: 1309251
Change-Id: Iaf7e209ac4bdc0592478a330e54ec987b17b829f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3693029
Commit-Queue: Olivia Yingst \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1011704}

Bug: 1309251
Change-Id: Ica899bfbc7395bf041473785e469368483219796

Reviewed-on: https://chromium-review.googlesource.com/3700042
WPT-Export-Revision: c7b2eac5f9222c98f754d308a3cc3a40ca053090

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=793062b4f6c1892c27347139afc6680e03b152d1

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

TIMEOUT: 1

Chrome

TIMEOUT: 1

Safari

TIMEOUT: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /credential-management/fedcm-revoke.sub.https.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8235b79a9293
[wpt PR 34376] - Reland "[FedCM] Make revoke test do actual network requests", a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8235b79a9293