Closed Bug 1773762 Opened 4 months ago Closed 4 months ago

Allow ATN(addons.thunderbird.net) to use mozAddonManager

Categories

(Toolkit :: Add-ons Manager, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
103 Branch
Tracking Status
firefox103 --- fixed

People

(Reporter: sancus, Assigned: rjl)

References

Details

Attachments

(1 file)

It seems that InstallTrigger is being removed. That's fine, but that leaves us with a need to use mozAddonManager on addons.thunderbird.net. Currently, it is hardcoded to addons.mozilla.org only.

We would like to add "addons.thunderbird.net" to the list of literals. It might be better to add a build-time configuration option for this, as that would allow us to add the domains we need without adding any risk to Firefox. We could also gate it behind a pref, but that is easier to modify than a build config option.

It would also be nice to have "addons-stage.thunderbird.net" added to the extensions.webapi.testing list.

Assignee: nobody → rob

Luca wants to take a look.

Flags: needinfo?(lgreco)
Severity: -- → N/A
Priority: -- → P5

The motivations from comment 0 looks both more than reasonable from my perspective.

Given where the valid hosts are enforced (both in production and testing), I think we could add the special cases needed for Thunderbird behind a buildtime #ifdef MOZ_THUNDERBIRD.

Flags: needinfo?(lgreco)
See Also: → 1764090
Attachment #9281337 - Attachment description: WIP: Bug 1773762 - Add ifdefs to allow Thunderbird builds to use mozAddonManager. → Bug 1773762 - Add ifdefs to allow Thunderbird builds to use mozAddonManager. r=rpl
Attachment #9281337 - Attachment description: Bug 1773762 - Add ifdefs to allow Thunderbird builds to use mozAddonManager. r=rpl → Bug 1773762 - Add ifdefs to allow Thunderbird builds to use mozAddonManager. r=mixedpuppy
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/integration/autoland/rev/e0df31655cc0
Add ifdefs to allow Thunderbird builds to use mozAddonManager. r=mixedpuppy
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.