1773762 - Allow ATN(addons.thunderbird.net) to use mozAddonManager

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P5)

Description

[Andrei [:sancus]]

It seems that InstallTrigger is being removed. That's fine, but that leaves us with a need to use mozAddonManager on addons.thunderbird.net. Currently, it is hardcoded to addons.mozilla.org only.

We would like to add "addons.thunderbird.net" to the list of literals. It might be better to add a build-time configuration option for this, as that would allow us to add the domains we need without adding any risk to Firefox. We could also gate it behind a pref, but that is easier to modify than a build config option.

It would also be nice to have "addons-stage.thunderbird.net" added to the extensions.webapi.testing list.

Comment 1

[Tomislav Jovanovic :zombie]

Luca wants to take a look.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

The motivations from comment 0 looks both more than reasonable from my perspective.

Given where the valid hosts are enforced (both in production and testing), I think we could add the special cases needed for Thunderbird behind a buildtime #ifdef MOZ_THUNDERBIRD.

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1773762 - Add ifdefs to allow Thunderbird builds to use mozAddonManager. r=mixedpuppy

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0df31655cc0
Add ifdefs to allow Thunderbird builds to use mozAddonManager. r=mixedpuppy

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e0df31655cc0