Closed Bug 1773767 Opened 8 months ago Closed 8 months ago

Update rust IPDL parser to latest revision and add test coverage

Categories

(Webtools :: Searchfox, enhancement)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: asuth, Assigned: asuth)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

:mccr8 did a ton of modernization of the syntax supported by the rust IPDL parser we use for searchfox at https://github.com/amccreight/ipdl_parser back in March which should make us able to understand maybe all of the IPDL stuff in the tree, so it would be nice to update to using this. I've been trying to push hard on making sure we have test coverage for things like this because it's so easy to break these things and not notice it, but it's also frequently a bit of an initial effort to bootstrap, so this has languished as my graphing work has gone slower than desired. However, graphing is finally here enough that it really wants the IPDL enhancements; bug 1773165 in particular could benefit.

So I'm going to mainly add the test coverage in this bug which hopefully should make it trivial for us to take updates in the future.

Note that I did file bug 1661067 on switching to using the in-tree parser for consistency, but that involves significantly more work. (And why would we do that if we've got an equivalent rust parser? Woo rust!)

Thanks! Sorry, I got stalled out trying to figure out the testing situation. Let me know if you want some help with figuring out what to test.

There's been one change to the parser since March, but I think it shouldn't cause any real issue.

Attached file Landed PR
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.