Remove XPCOM binary Module infrastructure
Categories
(Core :: XPCOM, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox104 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
Details
Attachments
(11 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
Bug 1773770: Part 4 - Migrate INI parser factory to static component registration. r=xpcom-reviewers
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
With bug 1770237, the only things keeping us from removing the old arcane and complicated module loader infrastructure are a few remaining modules which haven't been converted to static registration. Given how much the removal would simplify the component manager codebase, now is a good time to do it.
|
||
Updated•2 years ago
|
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
|
Assignee | |
Comment 4•2 years ago
|
||
|
|
Assignee | |
Comment 5•2 years ago
|
||
|
|
Assignee | |
Comment 6•2 years ago
|
||
|
|
Assignee | |
Comment 7•2 years ago
|
||
|
|
Assignee | |
Comment 8•2 years ago
|
||
|
|
Assignee | |
Comment 9•2 years ago
|
||
|
|
Assignee | |
Comment 10•2 years ago
|
||
|
|
Assignee | |
Comment 11•2 years ago
|
||
|
||
Comment 12•2 years ago
|
||
Pushed by maglione.k@gmail.com: https://hg.mozilla.org/integration/autoland/rev/6df39588ec9a Part 1 - Remove defunct layout module. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/62e49ca3f288 Part 2 - Migrage KeyValueStore to static component registration. r=asuth https://hg.mozilla.org/integration/autoland/rev/51b89b344d7f Part 3 - Migrate XRE module to static component registration. r=xpcom-reviewers,nika https://hg.mozilla.org/integration/autoland/rev/fe46df06e31a Part 4 - Migrate INI parser factory to static component registration. r=xpcom-reviewers,nika https://hg.mozilla.org/integration/autoland/rev/ac727812fd06 Part 5 - Migrate necko category entries to static registration. r=necko-reviewers,kershaw https://hg.mozilla.org/integration/autoland/rev/0e3233868101 Part 7 - Migrate PowerManagerService to static component registration. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/ac4c4a143ff7 Part 8 - Migrate Cocoa widget module to static component registration. r=mstange https://hg.mozilla.org/integration/autoland/rev/1d079a6ae89c Part 9 - Migrate widget component content proxies to static registration. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/45dbd95d94bb Part 10 - Migrate xpcshell to register components without defining a module. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/0862b3275742 Part 11 - Migrate TestRacingServiceManager to register factories directly. r=xpcom-reviewers,nika https://hg.mozilla.org/integration/autoland/rev/3538e99dd668 Part 12 - Remove XPCOM Module infrastructure. r=xpcom-reviewers,nika
|
||
Comment 13•2 years ago
•
|
||
Backed out 11 changesets (Bug 1773770) for causing bustages on nsComponentManager.obj.
Backout link
Push with failures <--> Bp-hybrid
Failure Log
Also c1 <--> c1 Failure Log
Also bc1 <--> bc1 Failure Log
|
|
||
Comment 14•2 years ago
|
||
Pushed by maglione.k@gmail.com: https://hg.mozilla.org/integration/autoland/rev/c99e93023059 Part 1 - Remove defunct layout module. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/1ee8d852d9d5 Part 2 - Migrage KeyValueStore to static component registration. r=asuth https://hg.mozilla.org/integration/autoland/rev/86e09dcdadde Part 3 - Migrate XRE module to static component registration. r=xpcom-reviewers,nika https://hg.mozilla.org/integration/autoland/rev/6dbe5fa1ad4f Part 4 - Migrate INI parser factory to static component registration. r=xpcom-reviewers,nika https://hg.mozilla.org/integration/autoland/rev/7e3a1a32a88d Part 5 - Migrate necko category entries to static registration. r=necko-reviewers,kershaw https://hg.mozilla.org/integration/autoland/rev/1b8ad6be2dce Part 7 - Migrate PowerManagerService to static component registration. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/b6a696897ca8 Part 8 - Migrate Cocoa widget module to static component registration. r=mstange https://hg.mozilla.org/integration/autoland/rev/f96e9664168d Part 9 - Migrate widget component content proxies to static registration. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/4ff5f4f0f5d1 Part 10 - Migrate xpcshell to register components without defining a module. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/e8a3a040b4c4 Part 11 - Migrate TestRacingServiceManager to register factories directly. r=xpcom-reviewers,nika https://hg.mozilla.org/integration/autoland/rev/72ace9ee39ae Part 12 - Remove XPCOM Module infrastructure. r=xpcom-reviewers,nika
|
|
||
Comment 15•2 years ago
•
|
||
Backed out 11 changesets (Bug 1773770) for causing bc failures on browser_xpcom_graph_wait.js.
Backout link
Push with failures <--> bc2
Failure Log
Also c1 <--> c1 Failure Log
|
|
||
Comment 16•2 years ago
|
||
Pushed by maglione.k@gmail.com: https://hg.mozilla.org/integration/autoland/rev/c8d7da3cf2ac Part 1 - Remove defunct layout module. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/a6ddc3cdc9ba Part 2 - Migrage KeyValueStore to static component registration. r=asuth https://hg.mozilla.org/integration/autoland/rev/b996cbbbc2f5 Part 3 - Migrate XRE module to static component registration. r=xpcom-reviewers,nika https://hg.mozilla.org/integration/autoland/rev/71f539b482ba Part 4 - Migrate INI parser factory to static component registration. r=xpcom-reviewers,nika https://hg.mozilla.org/integration/autoland/rev/337e76b67647 Part 5 - Migrate necko category entries to static registration. r=necko-reviewers,kershaw https://hg.mozilla.org/integration/autoland/rev/8f334c5dc0cd Part 7 - Migrate PowerManagerService to static component registration. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/c3fcdd7e88e5 Part 8 - Migrate Cocoa widget module to static component registration. r=mstange https://hg.mozilla.org/integration/autoland/rev/a48829529dd0 Part 9 - Migrate widget component content proxies to static registration. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/cdd28e0e3434 Part 10 - Migrate xpcshell to register components without defining a module. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/0501c85d3f58 Part 11 - Migrate TestRacingServiceManager to register factories directly. r=xpcom-reviewers,nika https://hg.mozilla.org/integration/autoland/rev/d35762c3242d Part 12 - Remove XPCOM Module infrastructure. r=xpcom-reviewers,nika
|
||
Comment 17•2 years ago
|
||
Backed out for causing mochitest failures on test_bug466599.xhtml
Backout link
Push with failures
Link to failure log
Failure line : TEST-UNEXPECTED-FAIL | widget/tests/test_bug466599.xhtml | data on system pasteboard is wrapped with charset metadata
|
|
||
Comment 18•2 years ago
|
||
Pushed by maglione.k@gmail.com: https://hg.mozilla.org/integration/autoland/rev/2a8f65417b66 Part 1 - Remove defunct layout module. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/e9ad07c96ab2 Part 2 - Migrage KeyValueStore to static component registration. r=asuth https://hg.mozilla.org/integration/autoland/rev/38e7b99ffbed Part 3 - Migrate XRE module to static component registration. r=xpcom-reviewers,nika https://hg.mozilla.org/integration/autoland/rev/7a63d8676bf0 Part 4 - Migrate INI parser factory to static component registration. r=xpcom-reviewers,nika https://hg.mozilla.org/integration/autoland/rev/986a64a9e6b4 Part 5 - Migrate necko category entries to static registration. r=necko-reviewers,kershaw https://hg.mozilla.org/integration/autoland/rev/17894f5b3b41 Part 7 - Migrate PowerManagerService to static component registration. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/9089a97bcb26 Part 8 - Migrate Cocoa widget module to static component registration. r=mstange https://hg.mozilla.org/integration/autoland/rev/c78f0c4c8f3f Part 9 - Migrate widget component content proxies to static registration. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/26e47956508b Part 10 - Migrate xpcshell to register components without defining a module. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/d5374ef362c2 Part 11 - Migrate TestRacingServiceManager to register factories directly. r=xpcom-reviewers,nika https://hg.mozilla.org/integration/autoland/rev/ede55d570d1e Part 12 - Remove XPCOM Module infrastructure. r=xpcom-reviewers,nika
|
|
||
Comment 19•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2a8f65417b66
https://hg.mozilla.org/mozilla-central/rev/e9ad07c96ab2
https://hg.mozilla.org/mozilla-central/rev/38e7b99ffbed
https://hg.mozilla.org/mozilla-central/rev/7a63d8676bf0
https://hg.mozilla.org/mozilla-central/rev/986a64a9e6b4
https://hg.mozilla.org/mozilla-central/rev/17894f5b3b41
https://hg.mozilla.org/mozilla-central/rev/9089a97bcb26
https://hg.mozilla.org/mozilla-central/rev/c78f0c4c8f3f
https://hg.mozilla.org/mozilla-central/rev/26e47956508b
https://hg.mozilla.org/mozilla-central/rev/d5374ef362c2
https://hg.mozilla.org/mozilla-central/rev/ede55d570d1e
|
||
Comment 20•2 years ago
|
||
Hello, this busted Thunderbird builds entirely.
Unfortunately, this happened at the worst possible time because our devs in charge of the upstream sync are off.
Can anyone give us a hand or direction?
|
||
Comment 21•2 years ago
|
||
(In reply to Alessandro Castellani [:aleca] from comment #20)
Can anyone give us a hand or direction?
Bug 1773772 is on file for the Thunderbird porting work. Unfortunately I think there's no trivial fix here.
|
||
Comment 22•2 years ago
|
||
Backed out 11 changesets (Bug 1773770) because shouldn't have been landed during a soft freeze CLOSED TREE
Backout link: https://hg.mozilla.org/integration/autoland/rev/d845c7a1480c801737a45e5ff322814e3681c37a
|
||
Comment 23•2 years ago
|
||
Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/d845c7a1480c
|
|
Assignee | |
Comment 24•2 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #21)
(In reply to Alessandro Castellani [:aleca] from comment #20)
Can anyone give us a hand or direction?
Bug 1773772 is on file for the Thunderbird porting work. Unfortunately I think there's no trivial fix here.
There is a fairly trivial short-term fix, which is to move the module loading code to comm-central, and keep using it to load the existing module definitions until they're ported to the new system.
(In reply to Noemi Erli[:noemi_erli] from comment #22)
Backed out 11 changesets (Bug 1773770) because shouldn't have been landed during a soft freeze CLOSED TREE
Sorry, I missed the soft freeze email. I wasn't expecting it to start until today.
|
|
||
Comment 25•2 years ago
|
||
Pushed by maglione.k@gmail.com: https://hg.mozilla.org/integration/autoland/rev/0510b273fb41 Part 1 - Remove defunct layout module. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/4a95a78ea042 Part 2 - Migrage KeyValueStore to static component registration. r=asuth https://hg.mozilla.org/integration/autoland/rev/f79083f74800 Part 3 - Migrate XRE module to static component registration. r=xpcom-reviewers,nika https://hg.mozilla.org/integration/autoland/rev/44cbb33c7420 Part 4 - Migrate INI parser factory to static component registration. r=xpcom-reviewers,nika https://hg.mozilla.org/integration/autoland/rev/65a22f74e83a Part 5 - Migrate necko category entries to static registration. r=necko-reviewers,kershaw https://hg.mozilla.org/integration/autoland/rev/4f6088fc10ba Part 7 - Migrate PowerManagerService to static component registration. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/bf574fdeae25 Part 8 - Migrate Cocoa widget module to static component registration. r=mstange https://hg.mozilla.org/integration/autoland/rev/5c03d4ce7a77 Part 9 - Migrate widget component content proxies to static registration. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/46f717a86455 Part 10 - Migrate xpcshell to register components without defining a module. r=mccr8 https://hg.mozilla.org/integration/autoland/rev/5a716bde221c Part 11 - Migrate TestRacingServiceManager to register factories directly. r=xpcom-reviewers,nika https://hg.mozilla.org/integration/autoland/rev/6fb43403c00f Part 12 - Remove XPCOM Module infrastructure. r=xpcom-reviewers,nika
|
||
Comment 26•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0510b273fb41
https://hg.mozilla.org/mozilla-central/rev/4a95a78ea042
https://hg.mozilla.org/mozilla-central/rev/f79083f74800
https://hg.mozilla.org/mozilla-central/rev/44cbb33c7420
https://hg.mozilla.org/mozilla-central/rev/65a22f74e83a
https://hg.mozilla.org/mozilla-central/rev/4f6088fc10ba
https://hg.mozilla.org/mozilla-central/rev/bf574fdeae25
https://hg.mozilla.org/mozilla-central/rev/5c03d4ce7a77
https://hg.mozilla.org/mozilla-central/rev/46f717a86455
https://hg.mozilla.org/mozilla-central/rev/5a716bde221c
https://hg.mozilla.org/mozilla-central/rev/6fb43403c00f
Description
•