Don't force quick suggest to sync from remote settings on startup
Categories
(Firefox :: Address Bar, task, P1)
Tracking
()
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(1 file)
The quick suggest remote settings are synced on app startup due to this _queueSettingsSync() call.
In D148872, I'm hitting the following error in a preferences test (due to the fact that about:preferences loads UrlbarProviderQuickSuggest.jsm to grab some necessary properties on it for the Suggest preferences):
TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_openPreferences.js | [JavaScript Error: “Unknown Collection “main/quicksuggest”" {file: “resource://services-settings/RemoteSettingsClient.jsm” line: 147}]
The error is logged here in RemoteSettingsClient.
Even before D148872 I've noticed this same error sometimes on my machine. I don't recall that it caused tests to fail before, but regardless, it's an old problem.
I did some debugging and the error is due to trying to sync remote settings on startup. The collection isn't present when running tests.
Other remote settings consumers don't force syncs on startup. Instead they wait for a sync event before tring to get() data. I talked about this with Nan, and we decided that's what quick suggest should do too. Aside from the test failure, there's really no good reason to force a sync on app startup. Not forcing sync means the data will be loaded lazily on startup in new profiles (the RS doc says it "can sometimes be triggered minutes after browser starts"), which means suggestions from RS possibly won't appear for minutes after startup on new profiles, but that's OK.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4eaaa492cad8 Don't force quick suggest to sync from remote settings on startup. r=nanj
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 5•2 years ago
|
||
(In reply to Pulsebot from comment #3)
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4eaaa492cad8
Don't force quick suggest to sync from remote settings on startup. r=nanj
== Change summary for alert #34583 (as of Mon, 20 Jun 2022 13:09:20 GMT) ==
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 6% | paypal fcp | windows10-64-shippable-qr | fission warm webrender | 330.58 -> 310.62 |
| 4% | paypal loadtime | windows10-64-shippable-qr | fission warm webrender | 596.79 -> 570.92 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=34583
|
||
Comment 6•2 years ago
•
|
||
| backout uplift | ||
https://hg.mozilla.org/releases/mozilla-release/rev/e72f64a45e75
Backed out changeset 4eaaa492cad8 (bug 1773777) from release (103) for introducing 1782269
|
||
Updated•2 years ago
|
Description
•