1773879 - "Copy all Messages" does not work in Browser Console

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Alice0775 White]

Steps to reproduce:

1. Open Browser Console (Ctrl+Shift+J)
2. Right click on a error(warning) message
3. Select "Copy all Messages"
4. Paste to text editor

Actual Results:
Nothing was copied.
An error appears when selecting "Copy all Messages"

TypeError: can't access property "store", toolbox is null context-menu.js:341:42

Expected Results:
All Messages ware copied.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6afa33fe61fdd03767a9dab72be802864f4d1935&tochange=8082e637aa56b75dd24ebc38ed0684036329811c

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:nchevobbe, since you are the author of the regressor, bug 1764236, could you take a look?
For more information, please visit auto_nag documentation.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

I have a patch fixing this

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1773879 - [devtools] Fix Copy all Message context menu action in Browser Console. r=jdescottes.

We don't have a toolbox in the Browser Console, so we don't
need to have a Provider for its store.
A simple test is added, just checking that the action was
triggered.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82da2b52e0b5
[devtools] Fix Copy all Message context menu action in Browser Console. r=jdescottes.

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/82da2b52e0b5

Comment 6

[Alice0775 White]

Nicolas , can this uplift to ESR102?

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9281755 [details]
Bug 1773879 - [devtools] Fix Copy all Message context menu action in Browser Console. r=jdescottes.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Browser Console is used by Firefox engineers and Addon Developers, and we often advertise this feature for people reporting issues
• User impact if declined: Users can't use the "Copy All Messages" action in the Browser Console
• Fix Landed on Version: 103
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple couple line fix, only impacting this specific action; covered by an automated test

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9281755 [details]
Bug 1773879 - [devtools] Fix Copy all Message context menu action in Browser Console. r=jdescottes.

Approved for ESR102.1, thanks.

Comment 10

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/5e7127b2ba45