Closed
Bug 1773994
Opened 2 years ago
Closed 2 years ago
Remove unnecessary code in MESSAGE_OPEN for network messages
Categories
(DevTools :: Console, task)
DevTools
Console
Tracking
(firefox103 fixed)
RESOLVED
FIXED
103 Branch
| Tracking | Status | |
|---|---|---|
| firefox103 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
Details
Attachments
(1 file)
In https://searchfox.org/mozilla-central/rev/28ed523a3ed5dbf5f6b008cf1e28a9e8a8597b5e/devtools/client/webconsole/reducers/messages.js#503-508 we clone the Map but we don't need to. It's probably a leftover from the work where we made the Map mutable
|
Assignee | |
Comment 1•2 years ago
|
||
Depends on D149138
|
|
Assignee | |
Comment 2•2 years ago
|
||
After looking a bit more, it looks like the whole if block isn't necessary since changes made in Bug 1686440
Summary: Don't clone mutable Map in messages reducer → Remove unnecessary code in MESSAGE_OPEN for network messages
|
||
Updated•2 years ago
|
Attachment #9281028 -
Attachment description: Bug 1773994 - [devtools] Remove unnecessary cloning of mutable Map in messages reducer. r=ochameau. → Bug 1773994 - [devtools] Remove unnecessary code for network messages in MESSAGE_OPEN. r=ochameau.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/034347a53a02 [devtools] Remove unnecessary code for network messages in MESSAGE_OPEN. r=ochameau.
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox103:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•