Closed Bug 1774052 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 34406 - webauthn: Ignore unknown UserVerificationRequirement value

Categories

(Core :: DOM: Web Authentication, task, P4)

Product:
Core
Component:
DOM: Web Authentication
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
103 Branch
Tracking Flags:
Tracking Status
firefox103 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34406 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34406
Details from upstream follow.

Amos Lim <eui-sang.lim@samsung.com> wrote:

webauthn: Ignore unknown UserVerificationRequirement value

To comply to the spec, unknown UserVerificationRequirement
value should be ignored instead of throwing TypeError.

This fixups https://crrev.com/c/3678741

Bug: 1122731
Change-Id: If5357a2eb3d726b8c00b2dd4a7b9335cabbe4125

Reviewed-on: https://chromium-review.googlesource.com/3703037
WPT-Export-Revision: 738b25a37c3bbe680595aa930657c0d219731152

Component: web-platform-tests → DOM: Web Authentication
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 15 subtests

Status Summary

Firefox

OK : 1
PASS : 8
TIMEOUT: 6
NOTRUN : 53

Chrome

OK : 4
PASS : 60
FAIL : 8

Safari

OK : 4
PASS : 58
FAIL : 10

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /webauthn/createcredential-passing.https.html [wpt.fyi]: TIMEOUT
    • passing credentials.create() with default arguments: TIMEOUT
    • passing credentials.create() with rpId (hostname): NOTRUN
    • passing credentials.create() without rp.icon: NOTRUN
    • very short user id: NOTRUN
    • max length user id: NOTRUN
    • Uint8Array user id: NOTRUN
    • Int8Array user id: NOTRUN
    • Int16Array user id: NOTRUN
    • Int32Array user id: NOTRUN
    • Float32Array user id: NOTRUN
    • DataView user id: NOTRUN
    • passing credentials.create() without user.icon: NOTRUN
    • Int16Array challenge: NOTRUN
    • Int32Array challenge: NOTRUN
    • Float32Array challenge: NOTRUN
    • Float64Array challenge: NOTRUN
    • DataView challenge: NOTRUN
    • Absurdly large challenge: NOTRUN
    • pubKeyCredParams is empty Array: NOTRUN
    • EC256 pubKeyCredParams: NOTRUN
    • SelectEC256 pubKeyCredParams from a list: NOTRUN
    • passing credentials.create() with no timeout: NOTRUN
    • authenticatorSelection is undefined: NOTRUN
    • authenticatorSelection is empty object: NOTRUN
    • authenticatorSelection default values: NOTRUN
    • authenticatorSelection attachment undefined: NOTRUN
    • authenticatorSelection residentKey undefined: NOTRUN
    • authenticatorSelection residentKey false: NOTRUN
    • authenticatorSelection userVerification undefined: NOTRUN
    • authenticatorSelection userVerification discouraged: NOTRUN
    • attestation parameter: attestation is "none": NOTRUN
    • attestation parameter: attestation is "indirect": NOTRUN
    • attestation parameter: attestation is "direct": NOTRUN
    • attestation parameter: attestation is undefined: NOTRUN
    • extensions undefined: NOTRUN
    • extensions are empty object: NOTRUN
    • extensions are dict of empty strings: NOTRUN
  • /webauthn/getcredential-badargs-userverification.https.html [wpt.fyi]: TIMEOUT
  • /webauthn/getcredential-passing.https.html [wpt.fyi]: TIMEOUT
    • passing credentials.get() with default args: TIMEOUT
    • passing credentials.create() with no timeout: NOTRUN
    • rpId undefined: NOTRUN
    • passing credentials.get() with rpId (hostname): NOTRUN
    • authenticatorSelection userVerification undefined: NOTRUN
    • authenticatorSelection userVerification preferred: NOTRUN
    • authenticatorSelection userVerification discouraged: NOTRUN
    • extensions undefined: NOTRUN
    • extensions are empty object: NOTRUN
    • extensions are dict of empty strings: NOTRUN

New Tests That Don't Pass

  • /webauthn/createcredential-passing.https.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: OK)
    • passing credentials.create() with default arguments: TIMEOUT (Chrome: PASS, Safari: PASS)
    • passing credentials.create() with rpId (hostname): NOTRUN (Chrome: PASS, Safari: PASS)
    • passing credentials.create() without rp.icon: NOTRUN (Chrome: PASS, Safari: PASS)
    • very short user id: NOTRUN (Chrome: PASS, Safari: PASS)
    • max length user id: NOTRUN (Chrome: PASS, Safari: PASS)
    • Uint8Array user id: NOTRUN (Chrome: PASS, Safari: PASS)
    • Int8Array user id: NOTRUN (Chrome: PASS, Safari: PASS)
    • Int16Array user id: NOTRUN (Chrome: PASS, Safari: PASS)
    • Int32Array user id: NOTRUN (Chrome: PASS, Safari: PASS)
    • Float32Array user id: NOTRUN (Chrome: PASS, Safari: PASS)
    • DataView user id: NOTRUN (Chrome: PASS, Safari: PASS)
    • passing credentials.create() without user.icon: NOTRUN (Chrome: PASS, Safari: PASS)
    • Int16Array challenge: NOTRUN (Chrome: PASS, Safari: PASS)
    • Int32Array challenge: NOTRUN (Chrome: PASS, Safari: PASS)
    • Float32Array challenge: NOTRUN (Chrome: PASS, Safari: PASS)
    • Float64Array challenge: NOTRUN (Chrome: PASS, Safari: PASS)
    • DataView challenge: NOTRUN (Chrome: PASS, Safari: PASS)
    • Absurdly large challenge: NOTRUN (Chrome: PASS, Safari: PASS)
    • pubKeyCredParams is empty Array: NOTRUN (Chrome: PASS, Safari: PASS)
    • EC256 pubKeyCredParams: NOTRUN (Chrome: PASS, Safari: PASS)
    • SelectEC256 pubKeyCredParams from a list: NOTRUN (Chrome: PASS, Safari: PASS)
    • passing credentials.create() with no timeout: NOTRUN (Chrome: PASS, Safari: PASS)
    • authenticatorSelection is undefined: NOTRUN (Chrome: PASS, Safari: PASS)
    • authenticatorSelection is empty object: NOTRUN (Chrome: PASS, Safari: PASS)
    • authenticatorSelection default values: NOTRUN (Chrome: PASS, Safari: PASS)
    • authenticatorSelection attachment undefined: NOTRUN (Chrome: PASS, Safari: PASS)
    • authenticatorSelection residentKey undefined: NOTRUN (Chrome: PASS, Safari: PASS)
    • authenticatorSelection residentKey false: NOTRUN (Chrome: PASS, Safari: PASS)
    • authenticatorSelection userVerification undefined: NOTRUN (Chrome: PASS, Safari: PASS)
    • authenticatorSelection userVerification discouraged: NOTRUN (Chrome: PASS, Safari: PASS)
    • authenticatorSelection userVerification empty string: NOTRUN (Chrome: FAIL, Safari: FAIL)
    • authenticatorSelection userVerification empty object: NOTRUN (Chrome: FAIL, Safari: FAIL)
    • authenticatorSelection userVerification unknown value: NOTRUN (Chrome: FAIL, Safari: FAIL)
    • authenticatorSelection userVerification null: NOTRUN (Chrome: FAIL, Safari: FAIL)
    • attestation parameter: attestation is "none": NOTRUN (Chrome: PASS, Safari: PASS)
    • attestation parameter: attestation is "indirect": NOTRUN (Chrome: PASS, Safari: PASS)
    • attestation parameter: attestation is "direct": NOTRUN (Chrome: PASS, Safari: PASS)
    • attestation parameter: attestation is undefined: NOTRUN (Chrome: PASS, Safari: PASS)
    • extensions undefined: NOTRUN (Chrome: PASS, Safari: PASS)
    • extensions are empty object: NOTRUN (Chrome: PASS, Safari: PASS)
    • extensions are dict of empty strings: NOTRUN (Chrome: PASS, Safari: PASS)
  • /webauthn/getcredential-badargs-userverification.https.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: OK)
    • Bad userVerification: "required": TIMEOUT (Chrome: PASS, Safari: FAIL)
  • /webauthn/getcredential-passing.https.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: OK)
    • passing credentials.get() with default args: TIMEOUT (Chrome: PASS, Safari: PASS)
    • passing credentials.create() with no timeout: NOTRUN (Chrome: PASS, Safari: PASS)
    • rpId undefined: NOTRUN (Chrome: PASS, Safari: PASS)
    • passing credentials.get() with rpId (hostname): NOTRUN (Chrome: PASS, Safari: PASS)
    • authenticatorSelection userVerification undefined: NOTRUN (Chrome: PASS, Safari: PASS)
    • authenticatorSelection userVerification preferred: NOTRUN (Chrome: PASS, Safari: PASS)
    • authenticatorSelection userVerification discouraged: NOTRUN (Chrome: PASS, Safari: PASS)
    • authenticatorSelection userVerification empty string: NOTRUN (Chrome: FAIL, Safari: FAIL)
    • authenticatorSelection userVerification empty object: NOTRUN (Chrome: FAIL, Safari: FAIL)
    • authenticatorSelection userVerification unknown value: NOTRUN (Chrome: FAIL, Safari: FAIL)
    • authenticatorSelection userVerification null: NOTRUN (Chrome: FAIL, Safari: FAIL)
    • extensions undefined: NOTRUN (Chrome: PASS, Safari: PASS)
    • extensions are empty object: NOTRUN (Chrome: PASS, Safari: PASS)
    • extensions are dict of empty strings: NOTRUN (Chrome: PASS, Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/22d0ac78314e [wpt PR 34406] - webauthn: Ignore unknown UserVerificationRequirement value, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f45ed40270a1 [wpt PR 34406] - webauthn: Ignore unknown UserVerificationRequirement value, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f45ed40270a1

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox103: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.