1774054 - Firefox Color messed up my favorite theme (Find bar became irreversibly white)

Status: NEW

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Lucas Pestana]

Attachment: screenshot of Firefox Developer Edition with "Dark Space Full Transparent" theme applied; however, the Find bar is wrongly displayed in milky-white color

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.5005.125 Safari/537.36

Steps to reproduce:

I am a user of Firefox Developer Edition, I think it was at version 102. I am running Windows 10, version 21H2.
So here's what happened: I had Rayr's "Dark Space Full Transparent"¹ theme installed; its code is also available on GitHub and it has been forked from another theme called "Dark Space" by Nicothin². It is a nearly all-black theme, sporting an animated dark UI (including a black/dark Find bar that popped when pressing Ctrl+F); it had been working perfectly fine for many months now.
https://addons.mozilla.org/firefox/addon/dark-space-full-transparent/
https://addons.mozilla.org/firefox/addon/nicothin-space/

Then, I got a notification saying Firefox now had a new feature called Firefox Colors, which allows custmomization of the UI colors.

I hopped on tried and played around changing a few colors here and there. Then, dissatisfied with the results, I tried undoing a few of the changes I've made and it didn't work out well.
So, I clicked this cursed button: "Revert All" (the leftmost button on top)³.
³ https://static1.makeuseofimages.com/wordpress/wp-content/uploads/2022/01/firefox-color-addon-screenshot.png

Actual results:

After that, my theme glitched and got corrupted, and now the Find bar always appears in a milky-white color, instead of the theme's default black color. I am unable to undo or revert this one change, either from Color or from anywhere else.⁴
⁴ https://pbs.twimg.com/media/FU3NJdAXEBADYqO?format=jpg&name=large or https://preview.redd.it/p1rvtdrhyp491.png?width=1366&format=png&auto=webp&s=662e9cc9aa4af619f55373ed9ba466fd89f9da67

Expected results:

The Find bar should go back to the theme's default color, but it won't -- I just talked to Rayr the developer himself, and this is what he has said to over private messaging:

Alright, so from my understanding the element that controls the bottom toolbar is the same as the top search bar.
In Nicothin's version it's completely black. In my theme it's transparent, that's why it's showing the default gray color, or at least it should show it.
In your case I think it's bugged and it has replaced the default color with the milky white.
Getting kinda more technical: your problem should be impossible, because if there was a problem with my theme it should have also affected the top bar (both bars should have changed color); the only explanation I have for this is, that a certain bug is causing older assigned values to the bottom bar not getting overwritten by a transparent value.

.

I tried uninstalling and reinstalling the theme. It doesn't work.
I tried uninstalling the Firefox Color addon. Zero results.
I tried restoring Firefox. It didn't work either.
I tried fully uninstalling Firefox. Nope.
I tried disabling Firefox Sync. It took me a while to succeed in it, but it didn't solve my problem.
Finally, I tried uninstalling Developer Edition and using other editions of Firefox instead. The issue persists across different editions.

I then timidly tried reproducing corrupting another theme -- Nicothin's original "Dark Space" theme -- by having it installed and then playing around with Firefox Color customizing colors, and clicking "Undo" and "Revert All". It didn't work (fortunately), and the Find bar of "Dark Space" remains black, as it should be.

A number of other people I talked to suggested that I open about:support and then open my PC's "Profile directory" in Windows Explorer. I did it, I tried deleting or changing the extension's XPI file from there. It also doesn't work.

I have just tried contacting Rayr the developer; he was very kind in replying and tried looking into the code of both his theme and the original theme by Nicothin, but he found nothing he could fix on his end.

.

I suspect there must some setting buried down deep somewhere in my OS that must be affecting this one theme -- but I lack the technical knowledge to go for such a deep dive; and at this point, even if I had it, I'm starting to doubt whether it would really solve things or not.
What should I do? What files or settings do I need to dive into and change?

I know it may sound like a very trivial problem, but for me, it has become so annoying and aggravating that I don't even feel like using Firefox anymore.

PLEASE HELP ME. Thank you.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Rob Wu [:robwu]]

It is not likely for this bug to be caused by Firefox Color (https://github.com/mozilla/FirefoxColor/issues/1023#issuecomment-1156439950).

Does this bug also happen in a new browser profile? How about a different browser version, e.g. Firefox release, beta or Nightly?

Comment 3

[Lucas Pestana]

Unfortunately, yes. It persists across browser profiles, across multiple installations of the same edition (e.g., if I uninstall and then reinstall Developer Edition), and even across different editions of Firefox (Regular, Beta, Developer).
I have also tried uninstalling the Firefox Color addon, to no avail, sadly.

❝It is not likely for this bug to be caused by Firefox Color❞, you said.
The developer of the theme said something in the same vein: ❝your problem should be impossible (…)❞.

Yet, it did happen, right after I tried changing and then undoing said changes in theme colors using Firefox Color.
I've been using Firefox Developer Edition for almost a year now, and such a problem with this or any other theme had never happened to me. (And also, never had I even heard of Firefox Color before; this was my first and probably last time using it.)

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Negritas Sergiu, Desktop QA]

Hello! I have tried to reproduce the issue with firefox 104.0a1 (2022-07-11) on Ubuntu 22.04, unfortunately I wasn't able to reproduce the issue on my end.
Could you please answer the following questions in order to further investigate this issue

1. Does this issue happen with a new profile? Here is a link on how to create one: https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles
2. Does this issue happen in the latest nightly? Here is a link from where you can download it: https://www.mozilla.org/en-US/firefox/channel/desktop/
3. Do you have any addons installed if so can you list them?

Comment 6

[Tomislav Jovanovic :zombie]

Lucas, can you please provide steps to reproduce, as it seems QA wasn't able to?

Otherwise we would close this as incomplete.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:robwu, could you have a look please?

For more information, please visit BugBot documentation.

Comment 8

[Rob Wu [:robwu]]

FirefoxColor uses browser.theme.reset(), but that has known bugs (e.g. bug 1415267, bug 1542026).