1774074 - moz-phab self-update always fails with incorrect target path

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P2)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

> moz-phab self-update
FileNotFoundError: [WinError 3] The system cannot find the path specified: 'C:\\Users\\sasch\\AppData\\Local\\Programs\\Python\\Python310\\Scripts\\moz-phab.exe\\moz-phab.exe' -> 'C:\\Users\\sasch\\AppData\\Local\\Programs\\Python\\Python310\\Scripts\\moz-phab.exe\\moz-phab-temp.exe'
Run moz-phab again with '--trace' to show debugging output
Sentry is attempting to send 2 pending error messages
Waiting up to 2 seconds
Press Ctrl-Break to quit

Windows seems to report the file path instead of the directory path here.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: updater: use `sys.argv[0]` to resolve script dir (Bug 1774074) r?zeid

Using sys.path[0] to resolve the script directory works on
Linux/MacOS, however on Windows the full path to the starting
script is passed as `sys.path[0] instead of the directory to
the script.

Change how we define script_dir to using sys.argv[0] which
is the path to the script used to start Python. The parent
directory to this value is the script directory.

Comment 2

[Connor Sheehan [:sheehan]]

Should be fixed after 1.2.3 is released.

Comment 3

[Connor Sheehan [:sheehan]]

Just to clarify - the issue with the paths being incorrect will be fixed in the new version. However I'm doing some investigating and it seems the self-update mechanism has never worked on Windows in the past. I'm going to disable it for now in a new bug.