1774117 - Calendar view reloads when switching tabs

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Geoff Lankow (:darktrojan)]

In switchToView we deactivate the current view and then activate the new view, but we shouldn't do this if they're the same view. It forces the view to reload.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1774117 - Only deactivate the current calendar view if it's being hidden. r=#thunderbird-reviewers

Short-circuits switchToView, if the new view is the same as the old view, so that we don't call .isActive = false and .clearItems() on it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/10534776b797
Only deactivate the current calendar view if it's being hidden. r=#thunderbird-reviewers,mkmelin

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9281331 [details]
Bug 1774117 - Only deactivate the current calendar view if it's being hidden. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: calendar view reloads itself every time you switch tab to it
Testing completed (on c-c, etc.): landed yesterday
Risk to taking this patch (and alternatives if risky):

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9281331 [details]
Bug 1774117 - Only deactivate the current calendar view if it's being hidden. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 102.0beta7:
https://hg.mozilla.org/releases/comm-beta/rev/fa315c7984ab