Closed Bug 1774182 Opened 2 years ago Closed 2 years ago

[wdspec] Improve and add missing "no such element" error tests for WebDriver classic commands where needed

Categories

(Testing :: geckodriver, enhancement, P1)

Product:
Testing
Component:
geckodriver
Version:
Default
Type:
enhancement
Points:
3

Tracking

(firefox108 fixed)

Status:
RESOLVED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox108 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [webdriver:m5], [wptsync upstream])

Attachments

(1 file, 3 obsolete files)

Bug 1774182 - [wdspec] Enhance "no such element" tests for WebDriver classic commands.
48 bytes, text/x-phabricator-request
Details | Review

On bug 1772484 the stale element reference tests will be improved and a lot of new ones are getting added for commands that require the check but missed to have such a test.

This bug covers the counter part for no such element errors. Getting it landed before bug 1692468 doesn't seem to be possible and as such delaying it looks like the better strategy here.

Before we can push possible patches on this bug we will have to wait for an agreement on bug https://github.com/w3c/webdriver/pull/1667.

URL: https://github.com/w3c/webdriver/pull...

Because the browsing context gets destroyed the list of known
elements will be gone and the new browsing context will not have
any known elements. As such referring to an element id from the
former browsing context has to fail with a no such element error.

Depends on D149268

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Points: --- → 3
Priority: -- → P1
Whiteboard: [webdriver:m4]
Attachment #9281225 - Attachment description: Bug 1774182 - [wdspec] Cross-group navigation has to result in `no such element` errors. → WIP: Bug 1774182 - [wdspec] Cross-group navigation has to result in `no such element` errors.
Attachment #9281226 - Attachment description: Bug 1774182 - [marionette] Element references for different browsing contexts have to fail with "no such element" errors. → WIP: Bug 1774182 - [marionette] Element references for different browsing contexts have to fail with "no such element" errors.
Attachment #9281227 - Attachment is obsolete: true
Attachment #9281226 - Attachment description: WIP: Bug 1774182 - [marionette] Element references for different browsing contexts have to fail with "no such element" errors. → Bug 1774182 - [wdspec] Enhance "no such element" tests for WebDriver classic commands.
Attachment #9281225 - Attachment is obsolete: true
Status: ASSIGNED → NEW
Whiteboard: [webdriver:m4] → [webdriver:m4][webdriver:m4:blocked]
Whiteboard: [webdriver:m4][webdriver:m4:blocked] → [webdriver:m4:blocked]
Priority: P1 → P2
Whiteboard: [webdriver:m4:blocked] → [webdriver:backlog:blocked]
No longer blocks: 1770420
Blocks: 1790361
Priority: P2 → P1
Whiteboard: [webdriver:backlog:blocked] → [webdriver:m5:blocked]

The changes for bug 1692468 shouldn't affect the current behavior of our WebDriver classic implementation. As such I want to see these tests to be added first to ensure that no regression will happen.

Blocks: 1692468
URL: https://github.com/w3c/webdriver/pull...
Status: NEW → ASSIGNED
No longer depends on: 1692468
Whiteboard: [webdriver:m5:blocked] → [webdriver:m5]
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77a9f0ad9a10
[wdspec] Enhance "no such element" tests for WebDriver classic commands. r=webdriver-reviewers,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36761 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m5] → [webdriver:m5], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/77a9f0ad9a10

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
Upstream PR merged by moz-wptsync-bot
Attachment #9281226 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: