Closed Bug 1774189 Opened 2 years ago Closed 2 years ago

Firefox View should show tab pickup list if a second desktop device is connected (shouldn't require mobile device)

Categories

(Firefox :: General, defect)

Desktop
All
defect
Points:
2

Tracking

()

RESOLVED FIXED
103 Branch
Tracking Status
firefox103 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view])

Attachments

(1 file)

https://searchfox.org/mozilla-central/rev/4519912ada795963299e4ba84c324adba762eff3/browser/components/firefoxview/tabs-pickup.js#55-60

says:

    this.registerSetupState({
      uiStateIndex: 1,
      name: "no-mobile-device",
      exitConditions: () => {
        return this.mobileDeviceConnected;
      },
    });

This isn't right - the step should be passed if there is any active secondary device, and we should show tabs from that device, even if it's a desktop device.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED

(In reply to :Gijs (he/him) from comment #0)

This isn't right - the step should be passed if there is any active secondary device, and we should show tabs from that device, even if it's a desktop device.

That wasn't my understanding of how we wanted this to work. I thought we had agreed that showing the tab pickup list was only conditional on there being a 2ndary device to show tabs from, but that the setup flow was primarily concerned with driving mobile adoption and we did want to show that step even if another desktop device was already connected.

If that decision changed then your patch looks good, but I either missed that decision or we're looking at different documents?

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Sam Foster [:sfoster] (he/him) from comment #2)

(In reply to :Gijs (he/him) from comment #0)

This isn't right - the step should be passed if there is any active secondary device, and we should show tabs from that device, even if it's a desktop device.

That wasn't my understanding of how we wanted this to work. I thought we had agreed that showing the tab pickup list was only conditional on there being a 2ndary device to show tabs from, but that the setup flow was primarily concerned with driving mobile adoption and we did want to show that step even if another desktop device was already connected.

I'm confused about how you see this distinction working in practice. We only ever show either the tab pickup list or the setup flow. So if the user has a secondary device and we want to show the tab pickup list, that means we need to be able to pass all the steps in the setup flow, right?

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(sfoster)
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fbd109ab0db3
allow continuing past connecting a mobile device if you have a second desktop device, r=sfoster

(In reply to :Gijs (he/him) from comment #3)

I'm confused about how you see this distinction working in practice. We only ever show either the tab pickup list or the setup flow. So if the user has a secondary device and we want to show the tab pickup list, that means we need to be able to pass all the steps in the setup flow, right?

Yeah I had a different read on what we are now calling the "promo" banner. Thanks for the patch.

Flags: needinfo?(sfoster)
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: