Closed Bug 1774213 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 34428 - Do not use `_get_fileversion()` in `webdriver_version()` on Windows

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox104 fixed)

Status:
RESOLVED FIXED
Milestone:
104 Branch
Tracking Flags:
Tracking Status
firefox104 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34428 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34428
Details from upstream follow.

Kagami Sascha Rosylight <saschanaz@outlook.com> wrote:

Do not use _get_fileversion() in webdriver_version() on Windows

For whatever reason chromedriver does not have a version descriptor. This causes version detection failure and leads to new download for every wpt run.

--version still works, so use that instead.

> ./chromedriver --version
ChromeDriver 102.0.5005.61 (0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819})
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ce1966df850b [wpt PR 34428] - Do not use `_get_fileversion()` in `webdriver_version()` on Windows, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ce1966df850b

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox104: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.