1774222 - Telemetry doesn't properly report whether the OpenH264 dylib can be successfully loaded

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, enhancement)

Description

[Jeff Muizelaar [:jrmuizel]]

It looks like the existing WEBRTC_SOFTWARE_H264_ENABLED probe only checks that we have the dylib and not that we can actually load and init it. We should add a probe that checks that we can successfully initialize it.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1774222. Add telemetry tracking successful GMP init.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: request.md

Comment 3

[Chris H-C :chutten]

Comment on attachment 9281241 [details]
request.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Jeff Muizelaar is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fee26330efc
Add telemetry tracking successful GMP init. r=bwc

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9281238 [details]
Bug 1774222. Add telemetry tracking successful GMP init.

Beta/Release Uplift Approval Request

• User impact if declined: We don't have visibility into GMP init failures
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just adds some telemetry
• String changes made/needed:
• Is Android affected?: Yes

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/58f5a5873267
Add telemetry tracking successful GMP init. a=graft

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/58f5a5873267

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9281238 [details]
Bug 1774222. Add telemetry tracking successful GMP init.

Approved for 102 beta 8, thanks.

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/0e3721fc8f37

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/3fee26330efc