1774244 - Review logs for sensitive information leaks

Status: RESOLVED FIXED

(Toolkit :: Password Manager, task, P1)

Description

[Sergey Galich [:serg]]

Lets take another round of logging review and focus on removing logging of:

• passwords
• tokens
• crypto keys
• user input
• addresses
• credit card details
• visited URLs (debatable, may be sometimes we need it, but we should strip path and query parameters)

There is rarely a need to log these things and if there is such need it should be done locally only. We can not afford user posting their log while seeking help and accidentally exposing their sensitive information.

P.S. also this is a good chance to remove unnecessary logs if we have any. The less we log the better.

Comment 1

[Issam Mani [:issammani]]

Attachment: Bug 1774244 - Cleanup Password Manager Toolkit logs. r=sgalich

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92e6d5d2672d
Cleanup Password Manager Toolkit logs. r=sgalich

Comment 3

[Marian-Vasile Laza]

Backed out changeset 92e6d5d2672d (Bug 1774244) for causing bc failures on browser_username_select_dialog.js.
Backout link
Push with failures
Failure Log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79d41dfeadc6
Cleanup Password Manager Toolkit logs. r=sgalich

Comment 5

[Issam Mani [:issammani]]

(In reply to Marian-Vasile Laza from comment #3)

Backed out changeset 92e6d5d2672d (Bug 1774244) for causing bc failures on browser_username_select_dialog.js.
Backout link
Push with failures
Failure Log

It should be good now :)

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/79d41dfeadc6